Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s-cloud-provider version #636

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Update k8s-cloud-provider version #636

merged 2 commits into from
Dec 4, 2023

Conversation

panslava
Copy link
Contributor

@panslava panslava commented Dec 2, 2023

/assign @swetharepakula

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 2, 2023
@panslava panslava force-pushed the master branch 3 times, most recently from 360979f to a7f8b34 Compare December 4, 2023 07:02
swetharepakula
swetharepakula reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@swetharepakula
Copy link
Member

/approve

@bowei
Copy link
Member

bowei commented Dec 4, 2023 •
edited

can you split the commit between vendor and changes to our code

@panslava
Update k8s-cloud-provider to 1.25.0. Vendor changes
28d3677 
- After this commit repo will be unbuildable because of breaking changes
  in k8s-cloud-provider. Next commit will fix the build
@panslava
Change test mock signatures for new k8s-cloud-provider
f9c3aec 
- k8s-cloud-provider added "options ...cloud.Option" to every mock hook
  function signatures. This commit changes our mocks to have the same
  signature
- This commit fixes repo build
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@bowei
Copy link
Member

bowei commented Dec 4, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, panslava, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@bowei
Copy link
Member

bowei commented Dec 4, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit dafa3f6 into kubernetes:master Dec 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

@jiahuif jiahuif Awaiting requested review from jiahuif

Assignees

@bowei bowei

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@panslava @swetharepakula @bowei @k8s-ci-robot