-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to launch specified binary in local-up-cluster.sh, like: cinder-provisioner and so on #101
Comments
i am thinking we should have like a pre/post hooks in local-up-cluster.sh as local-up-cluster is in main k/k and should not know about binaries that are not in the main repo. so basically we can have scripts in our repo and need to set something in local-up-cluster.sh to call them |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…openshift-4.11-ose-openstack-cloud-controller-manager Updating ose-openstack-cloud-controller-manager images to be consistent with ART
Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
What happened:
We have several binaries in repo:
Now local-up-cluster.sh only support to launch and config openstack-cloud-controller-manager, is there any plan to support launching all of these above binaries in local-up-cluster.sh? That will help OpenLab to reduce the complexity of automation script, like: https://github.com/theopenlab/openlab-zuul-jobs/blob/master/playbooks/cloud-provider-openstack-acceptance-test-keystone-authentication-authorization/run.yaml#L86-L88 and https://github.com/theopenlab/openlab-zuul-jobs/blob/master/playbooks/cloud-provider-openstack-acceptance-test-keystone-authentication-authorization/run.yaml#L92-L98
What you expected to happen:
We can control to launch specified binary with some environment variables in local-up-cluster.sh, like: EXTERNAL_CLOUD_PROVIDER_BINARY do now.
How to reproduce it (as minimally and precisely as possible):
NA
Anything else we need to know?:
NA
Environment:
uname -a
):The text was updated successfully, but these errors were encountered: