Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] ListVolumes pagination doesn't work as expected #1383

Closed
kayrus opened this issue Jan 22, 2021 · 0 comments · Fixed by #1382
Closed

[cinder-csi-plugin] ListVolumes pagination doesn't work as expected #1383

kayrus opened this issue Jan 22, 2021 · 0 comments · Fixed by #1382
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kayrus
Copy link
Contributor

kayrus commented Jan 22, 2021

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:

The #969 PR introduced the pagination support, however the pagination didn't make sense, since the AllPages() method was used, which automatically fetches all pages.
This PR uses a proper pagination and requests only one page, when the MaxItems limit is provided.

What you expected to happen:

When ListVolumes is called with a limit, the function should return max the limited amount of volumes.

How to reproduce it:

Not possible. Limit was introduced as a spec and not used by any CSI controllers. However this bug can appear, when controllers start to set the limit option.

Anything else we need to know?:

Environment:

  • openstack-cloud-controller-manager(or other related binary) version:
  • OpenStack version:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants