Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI driver should not rely on device path reported by OpenStack #150

Closed
jsafrane opened this issue May 2, 2018 · 5 comments
Closed

CSI driver should not rely on device path reported by OpenStack #150

jsafrane opened this issue May 2, 2018 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jsafrane
Copy link
Member

jsafrane commented May 2, 2018

/kind bug

What happened:
I'm running CSI driver from this repo and my volume got attached as /dev/vdc, while CSI driver returned DevicePath: /dev/vdb as attachment metadata.

This volume cannot be mounted into a pod because NodePublish can't find the volume.

What you expected to happen:
The driver either reports DevicePath or it's able to find the volume on the node without trusting DevicePath.

How to reproduce it (as minimally and precisely as possible):
I don't know what I did to OpenStack to attach the volume as /dev/vdc instead of /dev/vdb (there is no vdb device), but since that happened I can reproduce the bug reliably by just creating a pod.

Environment:

  • openstack-cloud-controller-manager version:
    I don't have access to the actual servers...
# nova  version-list
Client supported API versions:
Minimum version 2.1
Maximum version 2.53

Server supported API versions:
+------+-----------+----------------------+-------------+---------+
| Id   | Status    | Updated              | Min Version | Version |
+------+-----------+----------------------+-------------+---------+
| v2.0 | SUPPORTED | 2011-01-21T11:33:21Z |             |         |
| v2.1 | CURRENT   | 2013-07-23T11:33:21Z | 2.1         | 2.38    |
+------+-----------+----------------------+-------------+---------+

# cinder version-list
Client supported API versions:
Minimum version 3.0
Maximum version 3.40

Server supported API versions:
+------+------------+----------------------+-------------+---------+
| Id   | Status     | Updated              | Min Version | Version |
+------+------------+----------------------+-------------+---------+
| v1.0 | DEPRECATED | 2016-05-02T20:25:19Z |             |         |
| v2.0 | SUPPORTED  | 2014-06-28T12:20:21Z |             |         |
| v3.0 | CURRENT    | 2016-02-08T12:20:21Z | 3.0         | 3.15    |
+------+------------+----------------------+-------------+---------+

  • OS (e.g. from /etc/os-release): Red Hat Enterprise Linux Server 7.5
  • Kernel (e.g. uname -a): 3.10.0-862.el7.x86_64
  • Install tools: manually
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 2, 2018
@jsafrane
Copy link
Member Author

jsafrane commented May 2, 2018

This has been fixed in Kubernetes internal Cidner volume plugin in kubernetes/kubernetes#33128 by introducing TrustDevicePath config option.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 30, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wozniakjan pushed a commit to cisco-sso/pvwatch that referenced this issue Jan 9, 2019
PV Watchdog automating manual procedures of cisco SOP regarding:
kubernetes/cloud-provider-openstack#150
kubernetes/kubernetes#33128

- watches on events for pods
- deletes a pod
    - that has relevant cinder emptyPath event
    - is in Pending phase
    - hasn't been deleted in past 60 sec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants