Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] Add availability zone topology awareness for ephemeral storage #1022

Merged
merged 1 commit into from
Apr 13, 2020
Merged

[cinder-csi-plugin] Add availability zone topology awareness for ephemeral storage #1022

merged 1 commit into from
Apr 13, 2020

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Apr 9, 2020 •
edited by lingxiankong

  • cinder-csi-plugin

What this PR does / why we need it:

Add availability zone support for ephemeral storage.

Which issue this PR fixes(if applicable):
fixes #1018

Special notes for reviewers:

Release note:

cinder-csi-plugin: Add availability zone topology awareness for ephemeral storage

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kayrus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 9, 2020
@kayrus
Copy link
Contributor Author

kayrus commented Apr 9, 2020

/assign @ramineni

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 9, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2020

Build succeeded.

@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2020
@jichenjc
Copy link
Contributor

should we add some release notes/doc update accordingly?

@kayrus
Copy link
Contributor Author

kayrus commented Apr 10, 2020

@jichenjc release notes are defined in the first message. you're not the first person asking me for release notes, when they are in place. do I miss something? or do I write them wrong?

@jichenjc
Copy link
Contributor

you are right, I think I missed that part for unknown reason ,(maybe it's my Friday...)
sorry for inconvenience

@kayrus
Copy link
Contributor Author

kayrus commented Apr 10, 2020

@jichenjc no problem, thanks for clarifying :)

@ramineni
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2020
@ramineni
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8041428 into kubernetes:master Apr 13, 2020
@kayrus kayrus deleted the ephemeral-az-awareness branch April 13, 2020 07:12
@kayrus kayrus mentioned this pull request Apr 14, 2020
Merged
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@kayrus
[cinder-csi-plugin] Add availability zone topology awareness for ephe…
b3062df 
…meral storage (kubernetes#1022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaper87 flaper87 Awaiting requested review from flaper87

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] ephemeral storage isn't aware about availability zone topology
4 participants
@kayrus @k8s-ci-robot @jichenjc @ramineni