Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[magnum-auto-healer] Support node group #1032

Merged

Conversation

openstacker
Copy link
Contributor

@openstacker openstacker commented Apr 15, 2020

What this PR does / why we need it:
Magnum supports node group for its k8s cluster, and its resize API
has been updated accordingly. Therefore, magnum-auto-healer needs
to pass in the correct node group name and the node count.

Which issue this PR fixes(if applicable):
fixes #1031

Release note:

[magnum-auto-healer] Support Magnum node group when proforming autohealing.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 15, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 19, 2020

Build succeeded.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2020
Magnum supports node group for its k8s cluster, and its resize API
has been updated accordingly. Therefore, magnum-auto-healer needs
to pass in the correct node group name and the node count.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented May 7, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented May 7, 2020

Build succeeded.

@lingxiankong
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit c7a42eb into kubernetes:master May 14, 2020
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Magnum supports node group for its k8s cluster, and its resize API
has been updated accordingly. Therefore, magnum-auto-healer needs
to pass in the correct node group name and the node count.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[magnum-auto-healer] Support nodegroup
3 participants