Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] make cascade deletion configurable #1040

Merged
merged 1 commit into from
Apr 29, 2020
Merged

[occm] make cascade deletion configurable #1040

merged 1 commit into from
Apr 29, 2020

Conversation

hamzazafar
Copy link
Contributor

@hamzazafar hamzazafar commented Apr 20, 2020 •
edited by lingxiankong

What this PR does / why we need it:
Make cascade deletion of load balancers configurable

If octavia is used, occm tries to perform cascade deletion of load balancers. Some Octavia provider drivers might not support cascade deletion, therefore this PR makes cascade deletion option configurable. By default, cascade deletion is enabled.

Special notes for reviewers:
Cascade deletion can be enabled/disabled by setting cascade-delete option in cloud-config file.

Release note:

[openstack-cloud-controller-manager] Make cascade deletion configurable when Octavia is enabled.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @hamzazafar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 20, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build failed.

@hamzazafar
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@hamzazafar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 20, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 20, 2020

Build succeeded.

@lingxiankong
Copy link
Contributor

Cascade deletion can be enabled/disabled by setting cascade-delete option in cloud-config file or by using annotation loadbalancer.openstack.org/cascade-delete

Can we only use config option? I don't think the service user should be able to config that.

@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2020
@hamzazafar
Copy link
Contributor Author

Can we only use config option? I don't think the service user should be able to config that.

I have dropped the annotation.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 23, 2020

Build succeeded.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 25, 2020
@lingxiankong
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-csi-manila

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 25, 2020

Build succeeded.

@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2020
@ramineni
Copy link
Contributor

@hamzazafar Thanks.
/lgtm

@lingxiankong
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2aa0ba8 into kubernetes:master Apr 29, 2020
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
make cascade deletion configurable (kubernetes#1040)
fc01a9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramineni ramineni ramineni left review comments

@adisky adisky adisky left review comments

@dims dims Awaiting requested review from dims

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hamzazafar @k8s-ci-robot @lingxiankong @jichenjc @ramineni @adisky