[occm] refactor keepClientIP and useProxyProtocol

[hamzazafar]

What this PR does / why we need it:
Refactor/Improve processing of loadbalancer.openstack.org/x-forwarded-for and loadbalancer.openstack.org/proxy-protocol annotations

Which issue this PR fixes(if applicable):
keepClientIP and useProxyProtocol options are only supported by Octavia. This PR fixes the following issues:

• For neutron lbaas, listener protocol should only be TCP ref, however when loadbalancer.openstack.org/x-forwarded-for annotation is specified, regardless of Octavia or neutron LBaaS, occm sets listener protocol to HTTP ref.
• Proxy Protocol is not supported by Neutron LBaaS, occm sets pool protocol to proxy, even for neutron LBaaS ref.
• OCCM throws an error when both loadbalancer.openstack.org/x-forwarded-for and loadbalancer.openstack.org/proxy-protocol annotations are specified together ref. This check is made after creating loadbalancer and listener resources. Ideally, such checks should be made before creating any resources.

Special notes for reviewers:

Release note:

[openstack-cloud-controller-manager] The annotations loadbalancer.openstack.org/x-forwarded-for and loadbalancer.openstack.org/proxy-protocol are only supported when Octavia is deployed.

[k8s-ci-robot]

Hi @hamzazafar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hamzazafar]

/assign @lingxiankong

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-unittest : SUCCESS in 3m 32s

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-format : SUCCESS in 6m 31s

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-acceptance-test-csi-cinder : SUCCESS in 11m 37s

[theopenlab-ci]

Build succeeded.

• cloud-provider-openstack-acceptance-test-lb-octavia : SUCCESS in 30m 23s

[theopenlab-ci]

Build failed.

• cloud-provider-openstack-acceptance-test-e2e-conformance : FAILURE in 1h 45m 40s

[theopenlab-ci]

Build failed.

• cloud-provider-openstack-acceptance-test-csi-manila : POST_FAILURE in 1h 51m 47s

[lingxiankong]

/ok-to-test

[lingxiankong]

/override openlab/cloud-provider-openstack-acceptance-test-csi-manila

/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance

[k8s-ci-robot]

@lingxiankong: Overrode contexts on behalf of lingxiankong: openlab/cloud-provider-openstack-acceptance-test-csi-manila, openlab/cloud-provider-openstack-acceptance-test-e2e-conformance

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-csi-manila

/override openlab/cloud-provider-openstack-acceptance-test-e2e-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lingxiankong]

/lgtm

[hamzazafar]

/lgtm

@lingxiankong is there anything that's blocking this PR to get merged?

[lingxiankong]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cloudprovider/providers/openstack/OWNERS [lingxiankong]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment