Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: add TLS client auth support #1123

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Auth: add TLS client auth support #1123

merged 1 commit into from
Sep 8, 2020

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jul 17, 2020 •
edited by lingxiankong

What this PR does / why we need it:

Adds a support for TLS client auth.

Which issue this PR fixes(if applicable):
fixes #1119

Special notes for reviewers:

Release note:

Added support for TLS client authentication against OpenStack for all components.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kayrus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2020
@kayrus kayrus mentioned this pull request Jul 17, 2020
Closed
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 17, 2020

Build failed.

@k8s-ci-robot
Copy link
Contributor

@kayrus: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 17, 2020

Build failed.

@adisky
Copy link
Contributor

adisky commented Jul 17, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2020
@lingxiankong
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-e2e-conformance

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lingxiankong
Copy link
Contributor

HTTPS is not enabled in my environment, @kayrus have you tested this PR?

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 24, 2020

Build succeeded.

@kayrus
Copy link
Contributor Author

kayrus commented Jul 24, 2020

HTTPS is not enabled in my environment, kayrus have you tested this PR?

@lingxiankong I also don't have TLS env. I added TLS auth support as it is done in common.

@lingxiankong
Copy link
Contributor

lingxiankong commented Jul 26, 2020 •
edited

HTTPS is not enabled in my environment, kayrus have you tested this PR?

@lingxiankong I also don't have TLS env. I added TLS auth support as it is done in common.

Well, based on the environments of both two of us, TLS is not in common :-) (kidding)

I'd rather we only merge code that has been tested in real environment so that we are confident that the added options are doing the right thing. So hopefully there will be someone popping in asking for TLS support or have HTTPS supported can help to test. Hope you could understand.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 5, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 5, 2020

Build succeeded.

@kayrus
Copy link
Contributor Author

kayrus commented Sep 5, 2020

@lingxiankong the TLS configuration code is quite common. See https://github.com/etcd-io/etcd/blob/b28a6272b73359591fe22bac5ac8cae8afdbe0cc/clientv3/yaml/config.go#L86 or https://github.com/gophercloud/utils/blob/e38af13814d1b40e82c64bb4d137b0634f629af0/terraform/auth/config.go#L192
From my perspective it is quite safe to merge it.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 5, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 5, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 5, 2020

Build succeeded.

@lingxiankong
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-lb-octavia

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Sep 7, 2020

Build succeeded.

@lingxiankong
Copy link
Contributor

/override openlab/cloud-provider-openstack-acceptance-test-csi-manila

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: Overrode contexts on behalf of lingxiankong: openlab/cloud-provider-openstack-acceptance-test-csi-manila

In response to this:

/override openlab/cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lingxiankong
Copy link
Contributor

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2020
@lingxiankong
Copy link
Contributor

@jichenjc @ramineni could you please review this one?

@jichenjc
Copy link
Contributor

jichenjc commented Sep 8, 2020 •
edited

/approve
looks good

@ramineni
Copy link
Contributor

ramineni commented Sep 8, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a52dcb into kubernetes:master Sep 8, 2020
@kayrus kayrus deleted the tls-auth branch September 8, 2020 09:46
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@kayrus
Auth: add TLS client auth support (kubernetes#1123)
3bcfcbf
@kayrus kayrus mentioned this pull request Mar 1, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[csi-cinder-provisioner] cloud.conf can add more feild that support keystone re-authentication?
6 participants
@kayrus @k8s-ci-robot @adisky @lingxiankong @jichenjc @ramineni