Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] update listener on Octavia annotation changes #1150

Merged
merged 1 commit into from
Aug 20, 2020
Merged

[occm] update listener on Octavia annotation changes #1150

merged 1 commit into from
Aug 20, 2020

Conversation

seanschneeweiss
Copy link
Contributor

What this PR does / why we need it:
This implements the update of the listener if one of the service annotations

  • loadbalancer.openstack.org/timeout-client-data
  • loadbalancer.openstack.org/timeout-member-connect
  • loadbalancer.openstack.org/timeout-member-data
  • loadbalancer.openstack.org/timeout-tcp-inspect
  • loadbalancer.openstack.org/x-forwarded-for

changes.
Currently, changing one of the service annotation has no effect.

Which issue this PR fixes(if applicable):
fixes #1149

Special notes for reviewers:
Updating loadbalancer.openstack.org/proxy-protocol is currently not handled. See the issue for more details.

Release note:

[openstack-cloud-controller-manager] Update listener if service annotation `loadbalancer.openstack.org/timeout-client-data`, `loadbalancer.openstack.org/timeout-member-connect`, `loadbalancer.openstack.org/timeout-member-data`, `loadbalancer.openstack.org/timeout-tcp-inspect` or `loadbalancer.openstack.org/x-forwarded-for` changes.

Sean Schneeweiss sean.schneeweiss@daimler.com, Daimler TSS GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @seanschneeweiss. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 6, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 6, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 6, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 6, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 6, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 6, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 6, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 6, 2020

Build succeeded.

@ramineni
Copy link
Contributor

ramineni commented Aug 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2020
@dims dims removed their request for review August 10, 2020 13:01
@seanschneeweiss
Copy link
Contributor Author

@ramineni Could you kindly provide us feedback if anything is missing to approve this PR?

@ramineni
Copy link
Contributor

/assign @lingxiankong

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build succeeded.

@seanschneeweiss
Copy link
Contributor Author

seanschneeweiss commented Aug 17, 2020 •
edited
Loading

@ramineni Unfortunately the jobs failed due to git clone https://github.com/kubernetes/kubernetes /home/zuul/src/k8s.io/kubernetes -b master which requires go 1.15.0 since this commit on Aug. 13.
Related to #1161

Detected go version: go version go1.14.4 linux/amd64.
Kubernetes requires go1.15.0 or greater.
Please install go1.15.0 or later.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build succeeded.

@seanschneeweiss
Copy link
Contributor Author

/test cloud-provider-openstack-acceptance-test-e2e-conformance
/test cloud-provider-openstack-acceptance-test-lb-octavia

@k8s-ci-robot
Copy link
Contributor

@seanschneeweiss: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-e2e-conformance
/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seanschneeweiss
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 19, 2020

Build succeeded.

@lingxiankong
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-lb-octavia

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 20, 2020

Build failed.

@lingxiankong
Copy link
Contributor

/test cloud-provider-openstack-acceptance-test-lb-octavia

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 20, 2020

Build succeeded.

@lingxiankong
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5302340 into kubernetes:master Aug 20, 2020
jichenjc pushed a commit to jichenjc/cloud-provider-openstack that referenced this pull request Sep 7, 2020
@seanschneeweiss @jichenjc
[occm] update listener on Octavia annotation changes (kubernetes#1150)
2820e57 
This implements the update of the listener if one of the service
annotations
* loadbalancer.openstack.org/timeout-client-data
* loadbalancer.openstack.org/timeout-member-connect
* loadbalancer.openstack.org/timeout-member-data
* loadbalancer.openstack.org/timeout-tcp-inspect
* loadbalancer.openstack.org/x-forwarded-for
changes.

Signed-off-by: Sean Schneeweiss <sean.schneeweiss@daimler.com>
This was referenced May 18, 2021
Closed
Closed
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@seanschneeweiss
[occm] update listener on Octavia annotation changes (kubernetes#1150)
1fb1bb7 
This implements the update of the listener if one of the service
annotations
* loadbalancer.openstack.org/timeout-client-data
* loadbalancer.openstack.org/timeout-member-connect
* loadbalancer.openstack.org/timeout-member-data
* loadbalancer.openstack.org/timeout-tcp-inspect
* loadbalancer.openstack.org/x-forwarded-for
changes.

Signed-off-by: Sean Schneeweiss <sean.schneeweiss@daimler.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingxiankong lingxiankong lingxiankong approved these changes

@anguslees anguslees Awaiting requested review from anguslees

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@lingxiankong lingxiankong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[occm] loadbalancer not updating when Octavia specific service annotations change
5 participants
@seanschneeweiss @k8s-ci-robot @ramineni @lingxiankong @sbueringer