Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] add octavia loadbalancer flavor option #1160

Merged
merged 2 commits into from
Aug 19, 2020
Merged

[occm] add octavia loadbalancer flavor option #1160

merged 2 commits into from
Aug 19, 2020

Conversation

phiphi282
Copy link
Contributor

What this PR does / why we need it:
This pr adds an option to specify the flavor-id used for the octavia loadbalancer.
The flavor-id can be set in the config or via annotation.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Flavors were being introduced in octavia version 4.0.0 if I am not mistaken.
I haven't found a way to check the octavia version from within the occm so if a check is needed here I would appreciate if someone can point me in the right direction here.

Release note:

[openstack-cloud-controller-manager] Add support to set octavia loadbalancer flavor-id.

@phiphi282
Add support to specify octavia flavor.
55062f3 
Flavor can be specified in config or via annotation.
Annotation overrides config default.
@phiphi282
Add short doc entry for flavor-id
312e563
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 17, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @phiphi282!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @phiphi282. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2020
@phiphi282
Copy link
Contributor Author

/assign @zetaab

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build failed.

@phiphi282 phiphi282 mentioned this pull request Aug 17, 2020
Closed
@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 17, 2020

Build succeeded.

zetaab
zetaab approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. However, we need fix tests first

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@ramineni
Copy link
Contributor

/retest

@ramineni
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2020
@phiphi282
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 18, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Aug 18, 2020

Build succeeded.

@phiphi282
Copy link
Contributor Author

Tests are working now again :)

@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7203e42 into kubernetes:master Aug 19, 2020
lingxiankong added a commit that referenced this pull request Aug 19, 2020
@lingxiankong
Revert "[occm] add octavia loadbalancer flavor option (#1160)"
4b1364b 
This reverts commit 7203e42.
@lingxiankong
Copy link
Contributor

Flavor was introduced in Octavia since version v2.6 (on 2019-01-25), for those deployments using Octavia prior to v2.6, load balancer creation will fail as the parameter flavor_id is not recognized.

@phiphi282 Please submit another PR to add the version check (example https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/util/openstack/loadbalancer.go#L88), otherwise, we have to revert this PR.

@phiphi282 phiphi282 mentioned this pull request Aug 19, 2020
Merged
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@phiphi282
[occm] add octavia loadbalancer flavor option (kubernetes#1160)
7ef6b80 
* Add support to specify octavia flavor.

Flavor can be specified in config or via annotation.
Annotation overrides config default.

* Add short doc entry for flavor-id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees

@jichenjc jichenjc

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@phiphi282 @k8s-ci-robot @ramineni @jichenjc @lingxiankong @zetaab