Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add description for os-TLSInsecure #1310

Merged
merged 1 commit into from Nov 10, 2020

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Nov 9, 2020

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1306

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@jichenjc jichenjc changed the title Add description for os-TLSInsecure [Doc] Add description for os-TLSInsecure Nov 9, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 9, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 9, 2020

Build succeeded.

@@ -143,6 +143,8 @@ The options in `Global` section are used for openstack-cloud-controller-manager
The name of an application credential to authenticate with. If `application-credential-id` is not set, the user name and domain need to be set.
* `application-credential-secret`
The secret of an application credential to authenticate with.
* `os-TLSInsecure`
By default, the usual TLS verification is performed. To override this behavior and accept insecure certificates, set `os-TLSInsecure` to `true` (defaults to `false`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the following?

If set to `true`, then the server’s certificate will not be verified. Default is `false`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@lingxiankong lingxiankong removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 10, 2020

Build succeeded.

@lingxiankong
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6465560 into kubernetes:master Nov 10, 2020
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

occm needs to support insecure certs
3 participants