Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] don't error on unsupported octavia provider #1357

Merged
merged 2 commits into from
Jan 10, 2021
Merged

[occm] don't error on unsupported octavia provider #1357

merged 2 commits into from
Jan 10, 2021

Conversation

notandy
Copy link
Contributor

@notandy notandy commented Jan 5, 2021 •
edited by lingxiankong

What this PR does / why we need it:
Emit's a warning instead of initialisation failure if an unsupported octavia provider plugin is used.

Which issue this PR fixes(if applicable):
fixes #1356

Special notes for reviewers:

Release note:

[openstack-cloud-controller-manager] Allow load balancer providers other than 'amphora' and 'octavia'.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 5, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @notandy!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @notandy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 5, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 5, 2021

Build succeeded.

@jichenjc
Copy link
Contributor

jichenjc commented Jan 6, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2021
@ialidzhikov ialidzhikov mentioned this pull request Jan 7, 2021
Closed
@ialidzhikov
Copy link
Contributor

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jan 7, 2021
@lingxiankong
Copy link
Contributor

Please also add a description for the option lb-provider (https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/openstack-cloud-controller-manager/using-openstack-cloud-controller-manager.md#load-balancer) that using other custom providers is allowed but only amphora provider is officially tested.

@notandy
Copy link
Contributor Author

notandy commented Jan 8, 2021

Please also add a description for the option lb-provider (https://github.com/kubernetes/cloud-provider-openstack/blob/master/docs/openstack-cloud-controller-manager/using-openstack-cloud-controller-manager.md#load-balancer) that using other custom providers is allowed but only amphora provider is officially tested.

sure, thanks.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 8, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 9, 2021
@jichenjc
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit e5e97a9 into kubernetes:master Jan 10, 2021
@lingxiankong lingxiankong mentioned this pull request Jan 10, 2021
Merged
@notandy notandy deleted the dont-error-on-unsupported-lb-provider branch January 11, 2021 13:11
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@notandy
[occm] don't error on unsupported octavia provider (kubernetes#1357)
23822b1 
* [occm] don't error on unsupported octavia provider

* [occm] add documentation entry about officially supported lb-provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguslees anguslees Awaiting requested review from anguslees

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees

@lingxiankong lingxiankong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[occm] octavia stopped working with custom provider driver
5 participants
@notandy @k8s-ci-robot @jichenjc @ialidzhikov @lingxiankong