Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[octavia-ingress-controller] Improve Ingress reconciliation #1418

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[octavia-ingress-controller] Improve Ingress reconciliation #1418

merged 1 commit into from
Mar 4, 2021

Conversation

lingxiankong
Copy link
Contributor

@lingxiankong lingxiankong commented Feb 25, 2021 •
edited

What this PR does / why we need it:

  • Refactored how the ingress controller reconciles resources in Octavia. Changed the way that all the pools and l7 policies were removed before creating new resources, which brings downtime of the Ingress service.
  • Improved log.
  • Moved octavia related utility functions to pkg/util/openstack/loadbalancer.go

Which issue this PR fixes(if applicable):
fixes #1417

Special notes for reviewers:

Release note:

[octavia-ingress-controller] Fixed the issue that pools and l7 policies are removed no matter how the Ingress is changed.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 25, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 25, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 25, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 25, 2021
@lingxiankong
Copy link
Contributor Author

/retest

1 similar comment
@bzhaoopenstack
Copy link

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 26, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor Author

/test cloud-provider-openstack-acceptance-test-lb-octavia

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 27, 2021

Build succeeded.

@ramineni
Copy link
Contributor

ramineni commented Mar 2, 2021

changes looks ok to me
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2021
@lingxiankong
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 40e9557 into kubernetes:master Mar 4, 2021
This was referenced Mar 5, 2021
Merged
Merged
@lingxiankong lingxiankong deleted the improve-octavia-ingress branch March 9, 2021 22:12
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@lingxiankong
[octavia-ingress-controller] Improve Ingress reconciliation (kubernet…
8695fd9 
…es#1418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[octavia-ingress-controller] Existing pools are rebuilt when updating Ingress
4 participants
@lingxiankong @bzhaoopenstack @k8s-ci-robot @ramineni