-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cinder-csi-plugin] custom StorageClass in Helm Chart #1455
[cinder-csi-plugin] custom StorageClass in Helm Chart #1455
Conversation
Hi @eumel8. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
guess this change don't need relesae notes. |
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
@eumel8 you still would need to bump chart version , lint charts seem to fail |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
5 similar comments
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
f73a2a5
to
76bf6ba
Compare
Build succeeded.
|
@lingxiankong Yes, this rebase was completly wrong, sorry. Hopefuly push --force is doing the right thing now |
Build succeeded.
|
Build succeeded.
|
Build succeeded.
|
@eumel8 Thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lingxiankong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [cinder-csi-plugin] custom StorageClass in Helm Chart * enable StorageClass default * fix snapshotclass exaple * re-format example * bump chart version, add maintainer * more bump chart version * [cinder-csi-plugin] custom StorageClass in Helm Chart * enable StorageClass default * fix snapshotclass exaple * re-format example * bump chart version, add maintainer * more bump chart version * Revert "more bump chart version" This reverts commit 553482f. * bump chart 1.3.6 * [cinder-csi-plugin] custom StorageClass in Helm Chart * enable StorageClass default * fix snapshotclass exaple * re-format example * [cinder-csi-plugin] custom StorageClass in Helm Chart * enable StorageClass default * fix snapshotclass exaple * re-format example * bump chart version, add maintainer * more bump chart version * remove maintainer * downsize storage class example
What this PR does / why we need it:
The pre-defined StorageClasses won't fit for every use case. Give the user the possibility to define their own StorageClasses or VolumeSnapShotClass
Which issue this PR fixes(if applicable):
none
Special notes for reviewers:
none
Release note: