New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[manila-csi-plugin] helm: added clusterID value #1516
[manila-csi-plugin] helm: added clusterID value #1516
Conversation
Build succeeded.
|
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be some unrelated whitespace changes included, but they look like improvements so OK by me.
/lgtm Outside the pkg/csi/manila/ tree so these probably won't work, adding raminieni ... |
@ramineni When you get a chance please help with this one. Thanks! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ramineni, tombarron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
#1459 added
--cluster-id
cmd arg. This PR makes it possible to set it via the Helm chart.Special notes for reviewers:
Release note: