Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin]Avoid create tag from metadata req of snapshot #1575

Merged
merged 1 commit into from Jul 14, 2021
Merged

[cinder-csi-plugin]Avoid create tag from metadata req of snapshot #1575

merged 1 commit into from Jul 14, 2021

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Jun 17, 2021 •
edited by lingxiankong

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #1545

Special notes for reviewers:

Release note:

[cinder-csi-plugin] Add metadata for creating snapshot if `--extra-create-metadata` is enabled in external-snapshotter.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 17, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 17, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 17, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 17, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 17, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 17, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 17, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 17, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 17, 2021

Build succeeded.

ramineni
ramineni reviewed Jun 17, 2021
View reviewed changes
pkg/csi/cinder/controllerserver.go
@@ -363,9 +363,6 @@ func (cs *controllerServer) CreateSnapshot(ctx context.Context, req *csi.CreateS
} else {
// Add cluster ID to the snapshot metadata
properties := map[string]string{cinderCSIClusterIDKey: cs.Driver.cluster}
for mKey, mVal := range req.Parameters {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jichenjc I dont understand what is the issue here?

@lingxiankong
Copy link
Contributor

/hold

Need discussion in the issue.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 29, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 29, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 29, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 29, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 29, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 29, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

/test cloud-provider-openstack-e2e-test-csi-cinder

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 30, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 30, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 30, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jul 1, 2021

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 1, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jul 2, 2021

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 2, 2021

Build succeeded.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jul 5, 2021

@lingxiankong @ramineni can you check this ? Thanks

@ramineni
Copy link
Contributor

ramineni commented Jul 5, 2021

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 5, 2021
@lingxiankong
Copy link
Contributor

Added release note, @jichenjc @ramineni please take a look if that looks good to you.

@jichenjc
Copy link
Contributor Author

@lingxiankong thanks, that looks good

@lingxiankong
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2021
@lingxiankong
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@jichenjc
Copy link
Contributor Author

/test pull-cloud-provider-openstack-check

@k8s-ci-robot k8s-ci-robot merged commit 3431885 into kubernetes:master Jul 14, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@jichenjc
Avoid create tag from metadata req of snapshot (kubernetes#1575)
e6d95b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramineni ramineni ramineni left review comments

@chrigl chrigl Awaiting requested review from chrigl

@ricolin ricolin Awaiting requested review from ricolin

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] Tag (metadata) from req.parameter behavior different for snapshot and volume
4 participants
@jichenjc @lingxiankong @k8s-ci-robot @ramineni