Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cinder-csi-plugin] Bump snapshotter version to 4.0.0 #1578

Merged
merged 1 commit into from
Jun 28, 2021
Merged

[cinder-csi-plugin] Bump snapshotter version to 4.0.0 #1578

merged 1 commit into from
Jun 28, 2021

Conversation

ramineni
Copy link
Contributor

What this PR does / why we need it:
This PR bumps snapshotter to 4.0.0 and also added support --extra-create-metadata tag.
Also updates other sidecars to latest version .
Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2021
@ramineni ramineni mentioned this pull request Jun 21, 2021
Closed
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 21, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2021
@ramineni
Copy link
Contributor Author

@jichenjc PTAL

@jichenjc
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit f4f8b9b into kubernetes:master Jun 28, 2021
MPV
MPV reviewed Nov 25, 2021
View reviewed changes
charts/cinder-csi-plugin/values.yaml
tag: v2.1.0
tag: v2.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might have known this already, either way — this change had great impact, in resolving this memory leak: kubernetes-csi/livenessprobe#94

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the info, seems this is not memory leak but memory usage high
but anyway, glad it fixed the problem and we adopted it

powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@ramineni
[cinder-csi-plugin] Bump snapshotter version to 4.0.0 (kubernetes#1578)
75295d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MPV MPV MPV left review comments

@jichenjc jichenjc jichenjc left review comments

@dims dims Awaiting requested review from dims

@ricolin ricolin Awaiting requested review from ricolin

Assignees

@lingxiankong lingxiankong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ramineni @lingxiankong @jichenjc @k8s-ci-robot @MPV