Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] Remove redundant imagePullPolicy #1602

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

ramineni
Copy link
Contributor

@ramineni ramineni commented Jul 21, 2021

What this PR does / why we need it:
imagePullPolicy is defined twice in some places , which overwirtes to specific value. This PR is to keep the value configurable.

Which issue this PR fixes(if applicable):
fixes #1598

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 21, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jul 21, 2021

Build succeeded.

@Happy2C0de
Copy link

@ramineni
Can we push this PR? This is a breaking bug, see fluxcd/flux2#1522 .
Mainly, kyaml used by Flux2 and kustomize break when there is a duplicate key within a given template.

Thanks for your efforts! 👍

@ramineni
Copy link
Contributor Author

@jichenjc @lingxiankong PTAL ^^

@jichenjc
Copy link
Contributor

/lgtm
/approve

small change, fast approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2155ee9 into kubernetes:master Jul 23, 2021
@Happy2C0de
Copy link

Thanks a lot! 👍

pierreprinetti pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Aug 23, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodeplugin-daemonset chart template - imagePullPolicy is defined multiple times
4 participants