Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

occm: Fix LoadBalancer deletion when the underlying LoadBalancer does… #1917

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

jichenjc
Copy link
Contributor

… not exist (#1913)

cherry pick #1913

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2022
@jichenjc
Copy link
Contributor Author

/approve

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022
@ialidzhikov
Copy link
Contributor

@jichenjc , thanks for the cherry-pick!

@chrigl
Copy link
Contributor

chrigl commented Jun 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2022
@ialidzhikov
Copy link
Contributor

/retest

@jichenjc
Copy link
Contributor Author

/test openstack-cloud-csi-cinder-e2e-test-release-124

@jichenjc
Copy link
Contributor Author

/test openstack-cloud-csi-manila-e2e-test-release-124

@chrigl
Copy link
Contributor

chrigl commented Jun 15, 2022

/override openstack-cloud-csi-manila-e2e-test-release-124
/override openstack-cloud-csi-cinder-e2e-test-release-124

Both components are not affected by those changes.

@k8s-ci-robot
Copy link
Contributor

@chrigl: Overrode contexts on behalf of chrigl: openstack-cloud-csi-cinder-e2e-test-release-124, openstack-cloud-csi-manila-e2e-test-release-124

In response to this:

/override openstack-cloud-csi-manila-e2e-test-release-124
/override openstack-cloud-csi-cinder-e2e-test-release-124

Both components are not affected by those changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrigl
Copy link
Contributor

chrigl commented Jun 15, 2022

Haha @jichenjc , race condition between the two of us :P

@k8s-ci-robot k8s-ci-robot merged commit a3fcece into kubernetes:release-1.24 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants