New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] Allow deleting LBs in ERROR status #2037
Conversation
In practice Octavia is quite an unreliable system. We should expect that load balancers will occasionally go into ERROR state for reasons as elaborate as race conditions and as simple as lack of resources to spawn a new Amphora VM. This commit makes sure that we allow deleting LBs in ERROR state, so that Services served by such LBs could be deleted and their creation retried. Obviously there's room for improvement, as we should probably detect LBs going into ERROR and attempt to delete and recreate them ourselves, but this patch is a low hanging fruit fix for the issue.
Hi @dulek. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/lgtm |
@stephenfin: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In practice Octavia is quite an unreliable system. We should expect that load balancers will occasionally go into ERROR state for reasons as elaborate as race conditions and as simple as lack of resources to spawn a new Amphora VM. This commit makes sure that we allow deleting LBs in ERROR state, so that Services served by such LBs could be deleted and their creation retried. Obviously there's room for improvement, as we should probably detect LBs going into ERROR and attempt to delete and recreate them ourselves, but this patch is a low hanging fruit fix for the issue.
In practice Octavia is quite an unreliable system. We should expect that load balancers will occasionally go into ERROR state for reasons as elaborate as race conditions and as simple as lack of resources to spawn a new Amphora VM. This commit makes sure that we allow deleting LBs in ERROR state, so that Services served by such LBs could be deleted and their creation retried. Obviously there's room for improvement, as we should probably detect LBs going into ERROR and attempt to delete and recreate them ourselves, but this patch is a low hanging fruit fix for the issue.
What this PR does / why we need it:
In practice Octavia is quite an unreliable system. We should expect that load balancers will occasionally go into ERROR state for reasons as elaborate as race conditions and as simple as lack of resources to spawn a new Amphora VM.
This commit makes sure that we allow deleting LBs in ERROR state, so that Services served by such LBs could be deleted and their creation retried.
Obviously there's room for improvement, as we should probably detect LBs going into ERROR and attempt to delete and recreate them ourselves, but this patch is a low hanging fruit fix for the issue.
Which issue this PR fixes(if applicable):
fixes #2036
Release note: