Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] Fixed the typo in the load balancing section in the README #2232

Merged
merged 2 commits into from Jun 21, 2023
Merged

[occm] Fixed the typo in the load balancing section in the README #2232

merged 2 commits into from Jun 21, 2023

Conversation

armagankaratosun
Copy link
Contributor

[occm] Fixed the typo in the load balancing section in the README

All the currently maintained binaries are:

  • openstack-cloud-controller-manager (occm)

What this PR does / why we need it:
If you set the variable with a lowercase "b", the template will not catch that and the secret that is created via the helm chart will lack the [LoadBalancer] section. the correct value should be "loadBalancer", instead of "loadbalancer", as you can see from the values.yaml.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 4, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @armagankaratosun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2023
@jichenjc
Copy link
Contributor

jichenjc commented May 4, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 4, 2023
@armagankaratosun
Copy link
Contributor Author

sorry, i made a mistake while rebasing my previous pull request #2183 and needed to reopen this.

@jichenjc
Copy link
Contributor

jichenjc commented May 6, 2023

seems there are similiar 2 commits in the PR and ,is it because of git rebase?

@armagankaratosun
Copy link
Contributor Author

seems there are similiar 2 commits in the PR and ,is it because of git rebase?

I made a typo once, then fixed it again.

@armagankaratosun
Copy link
Contributor Author

/retest-required

@armagankaratosun
Copy link
Contributor Author

hello @jichenjc, I don't understand why the tests are failing ( in my simple understanding, the linting is failing not because of me or my change but maybe I am doing something wrong). In my defense, this was a simple PR where I fix only the README (this doesn't mean that this is not important though). Can you please help me to identify what is wrong?

@mdbooth
Copy link
Contributor

mdbooth commented Jun 1, 2023

These were broken until recently. Might pass now.

/test openstack-cloud-csi-manila-e2e-test

However, you are right that we don't need to run them against a README change. There's stuff we can configure in prow to do this, but we need to be careful with it.

@jichenjc
Copy link
Contributor

jichenjc commented Jun 1, 2023

However, you are right that we don't need to run them against a README change. There's stuff we can configure in prow to do this, but we need to be careful with it.

right , previously there are changes that make some file change didn't run CI.. so need to be careful

now I am confused why it reports issue against helm chart, maybe you can try rebase?
or we can override the failure if it's possible

@armagankaratosun
Copy link
Contributor Author

However, you are right that we don't need to run them against a README change. There's stuff we can configure in prow to do this, but we need to be careful with it.

right , previously there are changes that make some file change didn't run CI.. so need to be careful

now I am confused why it reports issue against helm chart, maybe you can try rebase? or we can override the failure if it's possible

ok, trying to rebase again

@armagankaratosun
fixed the typo on loadbalancer config
e621b72 
fixed the typo on loadbalancer config
@kayrus
Copy link
Contributor

kayrus commented Jun 21, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@kayrus
Copy link
Contributor

kayrus commented Jun 21, 2023

/approve

@mdbooth
Copy link
Contributor

mdbooth commented Jun 21, 2023

An obvious fix.

/lgtm
/assign @zetaab

zetaab
zetaab approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thank you

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@mdbooth
Copy link
Contributor

mdbooth commented Jun 21, 2023

@armagankaratosun I think that lint check means you need to bump a version number in the helm charts, but:

  • honestly I haven't worked it out yet myself.
  • I don't understand why that would be needed for this PR.

I think @zetaab has knowledge of the deep magic?

@kayrus
Copy link
Contributor

kayrus commented Jun 21, 2023

Since this README.md file was modified under the chart dir, it's required to manually bump the minor chart version before the merge. See https://github.com/kubernetes/cloud-provider-openstack/pull/2254/files for example.

@armagankaratosun
Copy link
Contributor Author

armagankaratosun commented Jun 21, 2023 •
edited

Since this README.md file was modified under the chart dir, it's required to manually bump the minor chart version before the merge. See https://github.com/kubernetes/cloud-provider-openstack/pull/2254/files for example.

Oh, now it is clear, thanks! Then, I will bump up the version. TBH, now that I understand what the issue is, it started to make perfect sense 😄

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2023
@kayrus
Copy link
Contributor

kayrus commented Jun 21, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0c5e1d2 into kubernetes:master Jun 21, 2023
4 checks passed
@armagankaratosun armagankaratosun deleted the patch-1 branch June 21, 2023 14:35
mandre pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Feb 7, 2024
@armagankaratosun @mandre
[occm] Fixed the typo in the load balancing section in the README (ku…
489729c 
…bernetes#2232)

* fixed the typo on loadbalancer config

fixed the typo on loadbalancer config

* bumped the openstack-cloud-controller-manager chart version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@chrigl chrigl Awaiting requested review from chrigl

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@mdbooth mdbooth

@kayrus kayrus

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@armagankaratosun @k8s-ci-robot @jichenjc @mdbooth @kayrus @zetaab