[manila-csi-plugin]: Remove unused manila code #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
kayrus
force-pushed
the
manila-code-clean
branch
from
1a03585
to
69de40f
Compare
gman0
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Thanks for the clean up, @kayrus! The interfaces in compatibility and capability packages were there to fill in for missing Manila features, specifically share-from-snapshot with cephfs. The implementation for that never landed as it was not very performant, and Manila supports it in recent versions anyway. I'm ok for removing this.
/lgtm
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
9 tasks
mandre
pushed a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Resolves #2298
Which issue this PR fixes(if applicable):
fixes #2298
Special notes for reviewers:
Release note: