Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.25] fix gate #2312

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[release-1.25] fix gate #2312

merged 1 commit into from
Aug 2, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2283

/assign dulek

NONE

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 26, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 26, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2023
@dulek
Copy link
Contributor

dulek commented Jul 26, 2023

/test openstack-cloud-csi-cinder-e2e-test-release-125

@dulek dulek mentioned this pull request Jul 26, 2023
Merged
@jichenjc
Copy link
Contributor

/test openstack-cloud-csi-cinder-e2e-test-release-125

@kayrus
Copy link
Contributor

kayrus commented Jul 27, 2023

@jichenjc can we skip cinder tests?

@jichenjc
Copy link
Contributor

yes we do , but seems this will cause issue again in real CI :(

/override openstack-cloud-csi-cinder-e2e-test-release-125

@k8s-ci-robot
Copy link
Contributor

@jichenjc: Overrode contexts on behalf of jichenjc: openstack-cloud-csi-cinder-e2e-test-release-125

In response to this:

yes we do , but seems this will cause issue again in real CI :(

/override openstack-cloud-csi-cinder-e2e-test-release-125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kayrus
Copy link
Contributor

kayrus commented Jul 27, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@kayrus
Copy link
Contributor

kayrus commented Aug 2, 2023

@jichenjc can we merge this?

@jichenjc
Copy link
Contributor

jichenjc commented Aug 2, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1c69649 into kubernetes:release-1.25 Aug 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees

@dulek dulek

@kayrus kayrus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @dulek @jichenjc @kayrus @k8s-ci-robot