Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] Helm Chart: add metrics and Prometheus Operator support #2354

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

desaintmartin
Copy link
Member

@desaintmartin desaintmartin commented Aug 29, 2023

What this PR does / why we need it:

add metrics and Prometheus Operator support

Which issue this PR fixes(if applicable):
fixes #2350

Special notes for reviewers:

  • I separated http-server and podmonitor since the former can be used without the latter, although it requires two values to properly enable.
  • I "standardised" the way we start an http-server, and it may be incompatible with a Helm Release with extraArgs values already stating this flag.

Release note:

[cinder-csi-plugin] Helm Chart: add metrics and Prometheus Operator support

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2023
@desaintmartin desaintmartin marked this pull request as ready for review August 29, 2023 17:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2023
@dulek
Copy link
Contributor

dulek commented Aug 30, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 897bf41 into kubernetes:master Aug 31, 2023
5 checks passed
@MPV
Copy link
Contributor

MPV commented Jan 12, 2024

Only the deployment, not the daemonset also? 🤔 😊

For comparison, here's how it was added in kops (on both):

mandre pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cinder-csi-plugin: Helm Chart: add optional metrics and Prometheus Operator values
5 participants