Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.26] [occm] add max_retries_down support for octavia health monitors #2381

Merged
merged 1 commit into from Oct 4, 2023
Merged

[release-1.26] [occm] add max_retries_down support for octavia health monitors #2381

merged 1 commit into from Oct 4, 2023

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Oct 2, 2023

This is a cherry-pick of #2372

[occm] Add `max_retries_down` health monitors option support for OCCM LoadBalancer global config and service annotations

@kayrus kayrus requested a review from zetaab October 2, 2023 14:38
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 2, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2023
@kayrus
Copy link
Contributor Author

kayrus commented Oct 2, 2023

cc @mdbooth @dulek

@dulek
Copy link
Contributor

dulek commented Oct 4, 2023

/lgtm
/approve
/hold for 1.27 patch to get merged, @kayrus, feel free to remove once that happens.

This is helping with some ETP=Local issues, so I'm approving this even though it's backporting a feature.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@kayrus
Copy link
Contributor Author

kayrus commented Oct 4, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9c1cf73 into kubernetes:release-1.26 Oct 4, 2023
5 checks passed
@kayrus kayrus deleted the cherry-pick-monitor-1.26 branch October 4, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab Awaiting requested review from zetaab

@anguslees anguslees Awaiting requested review from anguslees

Assignees

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kayrus @dulek @k8s-ci-robot