Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: LbaasV2 method buildPoolCreateOpt #2404

Merged
merged 1 commit into from
Oct 11, 2023
Merged

test: LbaasV2 method buildPoolCreateOpt #2404

merged 1 commit into from
Oct 11, 2023

Conversation

majorchork
Copy link
Contributor

@majorchork majorchork commented Oct 8, 2023 •
edited
Loading

What this PR does / why we need it:
this pr adds unit test for buildPoolCreateOpt LbaasV2 method in loadbalancer.go
Which issue this PR fixes(if applicable):
refers #2400

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 8, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 8, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: majorchork / name: Sochukwuma Okoji (de1b07c)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @majorchork!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @majorchork. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 8, 2023
sakshi-1505
sakshi-1505 reviewed Oct 8, 2023
View reviewed changes
Copy link
Contributor

@sakshi-1505 sakshi-1505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove fixes from the PR description or else this PR will close the outstanding issue?

@majorchork majorchork force-pushed the test-buildPoolCreateOpt branch 2 times, most recently from 9540790 to 471a786 Compare October 8, 2023 13:55
@majorchork
Copy link
Contributor Author

Can you remove fixes from the PR description or else this PR will close the outstanding issue?

Once a PR is merged the issue should be closed, and a new one created as all the marked tests need to be reopened

@jichenjc
Copy link
Contributor

jichenjc commented Oct 9, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2023
@sakshi-1505
Copy link
Contributor

Can you remove fixes from the PR description or else this PR will close the outstanding issue?

Once a PR is merged the issue should be closed, and a new one created as all the marked tests need to be reopened

I didn't understand this but we don't want that parent tracking issue to get closed which will be if this PR gets merged. Issue #2400 not only tracks this tests but a lot of other unit tests where different contributors are involved which is why I suggested to use refer instead of close.

@majorchork
Copy link
Contributor Author

/retest

1 similar comment
@majorchork
Copy link
Contributor Author

/retest

@majorchork majorchork force-pushed the test-buildPoolCreateOpt branch 2 times, most recently from a053a84 to 6d28779 Compare October 9, 2023 12:50
dulek
dulek requested changes Oct 9, 2023
View reviewed changes
pkg/openstack/loadbalancer_test.go Outdated Show resolved Hide resolved
pkg/openstack/loadbalancer_test.go Outdated Show resolved Hide resolved
pkg/openstack/loadbalancer_test.go Outdated Show resolved Hide resolved
@dulek
Copy link
Contributor

dulek commented Oct 9, 2023

/retest

Error's unrelated.

@majorchork majorchork requested a review from dulek October 9, 2023 18:21
@dulek
Copy link
Contributor

dulek commented Oct 10, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@majorchork
Copy link
Contributor Author

@dulek all conflicts have been resolved

@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@majorchork
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@majorchork
Copy link
Contributor Author

Hello @jichenjc there was a small update to the function by @kayrus, so I had to update the tests, please re-add lgtm

@jichenjc
Copy link
Contributor

/lgtm

:)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 05118df into kubernetes:master Oct 11, 2023
6 checks passed
mandre pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Feb 6, 2024
@majorchork @mandre
test: LbaasV2 method buildPoolCreateOpt (kubernetes#2404)
ca82976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguslees anguslees Awaiting requested review from anguslees

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

@sakshi-1505 sakshi-1505 Awaiting requested review from sakshi-1505

@dulek dulek Awaiting requested review from dulek

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@majorchork @k8s-ci-robot @jichenjc @sakshi-1505 @dulek