-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: LbaasV2 method buildPoolCreateOpt #2404
test: LbaasV2 method buildPoolCreateOpt #2404
Conversation
|
Welcome @majorchork! |
Hi @majorchork. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove fixes
from the PR description or else this PR will close the outstanding issue?
9540790
to
471a786
Compare
Once a PR is merged the issue should be closed, and a new one created as all the marked tests need to be reopened |
/ok-to-test |
I didn't understand this but we don't want that parent tracking issue to get closed which will be if this PR gets merged. Issue #2400 not only tracks this tests but a lot of other unit tests where different contributors are involved which is why I suggested to use |
471a786
to
fd90684
Compare
/retest |
1 similar comment
/retest |
a053a84
to
6d28779
Compare
6d28779
to
168e101
Compare
/retest Error's unrelated. |
168e101
to
7dc443f
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7dc443f
to
8948aa7
Compare
@dulek all conflicts have been resolved |
/lgtm |
/retest |
8948aa7
to
bcc71fc
Compare
bcc71fc
to
de1b07c
Compare
/lgtm :) |
What this PR does / why we need it:
this pr adds unit test for buildPoolCreateOpt LbaasV2 method in loadbalancer.go
Which issue this PR fixes(if applicable):
refers #2400
Special notes for reviewers:
Release note: