Test get subnet

[majorchork]

What this PR does / why we need it:
this pr adds unit test for getSubnetID LbaasV2 method in loadbalancer.go
Which issue this PR fixes(if applicable):
refers #2400

Special notes for reviewers:

Release note:

NONE

[k8s-ci-robot]

Hi @majorchork. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dulek]

Seems like a case testing this codepath is missing?

[dulek]

/ok-to-test

[majorchork]

Seems like a case testing this codepath is missing?

yea! that was the one with the wrong name, I've updated it now

[pierreprinetti]

Reviewing Test_getSubnetID

[dulek]

/approve

I'll leave /lgtm for @pierreprinetti, I'm not 100% sure this is what he meant on the error checking front.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/openstack/OWNERS [dulek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[majorchork]

/approve

I'll leave /lgtm for @pierreprinetti, I'm not 100% sure this is what he meant on the error checking front.

Thanks a lot! Noted

[pierreprinetti]

/lgtm

[pierreprinetti]

Please rebase to enable the merge 🙏

[majorchork]

Please rebase to enable the merge 🙏

I already have seems like the bot forgot to remove the label, I'll just force push again and see if the bot picks it this time

[majorchork]

@k8s-ci-robot /verify needs-rebase

[pierreprinetti]

Please rebase to enable the merge 🙏

I already have seems like the bot forgot to remove the label, I'll just force push again and see if the bot picks it this time

What do you mean, "Your branch is ahead of 'origin/master' by 17 commits"? This is not expected. Your local master branch is not aligned with origin.

To rebase on origin's master, try:

git checkout test-getSubnetID
git fetch origin
git rebase origin/master

---

Additionally, if you want to get rid of those 17 commits on your local master branch, here's how to do it:

git checkout master
git fetch origin
git reset --hard origin/master
git clean -fdx

[majorchork]

git reset --hard origin/master

😅 my bad, it's ahead cause I've not published my local to my origin, I always just fetch upstream and merge then checkout to the branch I want to rebase before pushing, I never actually push the changes on my local origin
git fetch upstream (upstream is https://github.com/kubernetes/cloud-provider-openstack/master)
git merge upstream/master
git checkout test-getSubnetId
git rebase master
so my local master is ahead by all the changes I've fetched from the upstream,
I've updated, gotten rid of the commits, and rebased now

[pierreprinetti]

/lgtm