[release-1.28] Remove duplicate pflag.Parse calls #2467
Conversation
This is already handled by the earlier call to the (confusingly named) 'InitFlags' function provided by 'k8s.io/component-base/cli/flag' [1]. [1] https://github.com/kubernetes/component-base/blob/v0.28.1/cli/flag/flags.go#L51-L59 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit d0fc449)
This is already handled by the earlier call to the (confusingly named) 'InitFlags' function provided by 'k8s.io/component-base/cli/flag' [1]. We need to move the handling for the '--version' flag to after this to ensure we parse the flags first. [1] https://github.com/kubernetes/component-base/blob/v0.28.1/cli/flag/flags.go#L51-L59 Signed-off-by: Stephen Finucane <stephenfin@redhat.com> (cherry picked from commit de63646)
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
|
Note that the commits referenced don't actually exist on the remote and they only exist locally because garbage collector must not have run yet. Even with that caveat, I assume we still want to do things this way rather than cherry-pick the whole squashed change which includes feature'ish changes (the removal of glog handling code)? |
|
/cc @mdulko |
|
@stephenfin: GitHub didn't allow me to request PR reviews from the following users: mdulko. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stephenfin Hello, I think you tagged wrong person and you meant @dulek, funny enough I'm from Gdansk, Poland too. |
|
@mdulko Indeed I did. Apologies! 😄 |
|
Cheers @mdulko, I knew we'll meet one day. ;) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
This is a partial backport of #2325, namely the fixes for issues introduced by #2324. This will fix #2464.
Which issue this PR fixes(if applicable):
Fixes #2464
Special notes for reviewers:
Release note: