Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] CI: Fetch DevStack and k3s logs #2527

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Jan 25, 2024

What this PR does / why we need it:
This commit makes sure we're fetching and putting the logs of the DevStack services as well as k3s into the artifacts for every CI job.

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 25, 2024
@dulek dulek force-pushed the fetch-logs branch 3 times, most recently from cc5ea39 to 270922b Compare January 25, 2024 12:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 25, 2024
@dulek
Copy link
Contributor Author

dulek commented Jan 25, 2024

/hold

Logs are not gathered on failure, need to move this to a separate playbook.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@dulek dulek force-pushed the fetch-logs branch 2 times, most recently from d781fcf to 047179c Compare January 25, 2024 14:59
This commit makes sure we're fetching and putting the logs of the
DevStack services as well as k3s into the artifacts for every CI job.
@jichenjc
Copy link
Contributor

seems something wrong like other PRs

        "local-path-provisioner-84db5d44d9-b7s5x    0/1     Pending             0          5m23s   <none>      <none>       <none>           <none>",
        "coredns-6799fbcd5-p7m2z                    0/1     Pending             0          5m23s   <none>      <none>       <none>           <none>",
        "openstack-cloud-controller-manager-rhpgn   0/1     ImageInspectError   0          2m24s   10.1.0.38   k3s-master   <none>           <none>",

@dulek
Copy link
Contributor Author

dulek commented Jan 26, 2024

Even though tests fail for an unrelated reason logs are available in job results!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024
@jichenjc
Copy link
Contributor

/retest

@jichenjc
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 119a3ea into kubernetes:master Jan 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants