Commits on Feb 7, 2024

1. [occm] Make sure we don't mask LB tests failures and fix what was fai… …

   …ling (kubernetes#2360)
   
   * Compare proper LB name for shared LBs
   
   With shared LBs we distinguish the elements by tagging them with the
   proper name of the LB that would be created for a Service if it wasn't
   created as shared. This commit fixes that comparison for listener
   deletion as code was always comparing the name of the primary LB.
   
   * Fix shared LBs tests
   
   PR kubernetes#2190 prohibited sharing an LB that is internal for security reasons.
   This commit fixes the shared LBs tests to not create internal LBs.
   
   * Make sure we don't mask LB tests failures
   
   In `test-lb-service.sh` we do `trap "delete_resources" EXIT` to make
   sure we cleanup resources on a test failure. In there, we only fetched
   the `$?` after making a check for `${AUTO_CLEAN_UP}`, which itself
   alters the code to 0, so function always returns success. This means
   tests can never really fail.
   
   This commit fixes it by making sure `$ERROR_CODE` is fetched at the very
   beginning of the cleanup function.

   

   dulek committed Feb 7, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for d7ffecb
   • Browse repository at this point

   Copy the full SHA

   d7ffecb View commit details

   Browse the repository at this point in the history