Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] [manila-csi-plugin] Update Cinder and Manila CSI charts maintainers #2583

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Apr 24, 2024

What this PR does / why we need it:

The GitHub account @brtknr does not exist anymore and our chart linter complains about this. This commit adds me as the maintainer.

Which issue this PR fixes(if applicable):
fixes #2582

Special notes for reviewers:

Release note:

Maintainer for Cinder and Manila CSI charts is updated.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 24, 2024
@dulek
Copy link
Contributor Author

dulek commented Apr 24, 2024

/hold

It's a terrible idea to add me, we don't use Helm in our products, so this is looking for a better maintainer candidate.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
The GitHub account brtknr does not exist anymore and our chart linter
complains about this. This commit adds Matt and Michał as the maintainers.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
Copy link
Contributor

@mnasiadka mnasiadka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mnasiadka
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@mnasiadka: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek dulek changed the title cinder-csi-plugin] [manila-csi-plugin] Update Cinder and Manila CSI charts maintainers [cinder-csi-plugin] [manila-csi-plugin] Update Cinder and Manila CSI charts maintainers Apr 25, 2024
@dulek
Copy link
Contributor Author

dulek commented Apr 25, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@zetaab
Copy link
Member

zetaab commented Apr 25, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@zetaab
Copy link
Member

zetaab commented Apr 25, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6387cbb into kubernetes:master Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
5 participants