CCM does not start with K8s 1.20 dependencies

[piepmatz]

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

The CCM binary instantly exits with --cloud-provider cannot be empty, even though the flag is provided. The binary doesn't react to any flags at all, e.g. --version and -h have no impact.

I noticed this with a different, private CCM after updating the K8s dependencies to 1.20 and wanted to look how others have solved the issue. #429 by @nicolehanjing looked promising, but results in the same error that I was trying to solve.

What you expected to happen:

CCM should react on flags.

How to reproduce it (as minimally and precisely as possible):

make
.build/bin/vsphere-cloud-controller-manager.linux_amd64 --cloud-provider=foo

Anything else we need to know?:

@nicolehanjing also updated the AWS CCM's dependencies to K8s 1.20 in kubernetes/cloud-provider-aws#151. Things seem to work there as expected. Maybe because the cobra command is built differently.

Environment:

• vsphere-cloud-controller-manager version: d4c2a94 (after merging Bump k8s.io/kubernetes to 1.20.2 #429)
• OS (e.g. from /etc/os-release): Docker golang:1.15 and macOS 10.14.6

[piepmatz]

It's a K8s upstream bug: kubernetes/cloud-provider#44

[nicolehanjing]

Hi @piepmatz
I have a PR out for fixing this issue: #434
There is another PR to fix the upstream bug: kubernetes/kubernetes#98210