Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove controller-runtime dependency #840

Closed
2 tasks done
XudongLiuHarold opened this issue Jan 24, 2024 · 2 comments · Fixed by #847
Closed
2 tasks done

Remove controller-runtime dependency #840

XudongLiuHarold opened this issue Jan 24, 2024 · 2 comments · Fixed by #847
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@XudongLiuHarold
Copy link
Member

XudongLiuHarold commented Jan 24, 2024

What would you like to be added?

Currently, cloud provider vsphere has sigs.k8s.io/controller-runtime package dependency which could be a potential blocker for the future release.
Because if we rely on controller-runtime, we can only support new k8s version by waiting until the controller-runtime supports it, it significantly slows down our process to release to support new k8s version.

Why is this needed?

Therefore, we need to remove the controller-runtime encapsulation and use client-go directly in our cloud-provider-vsphere repo.

Following files need to be refactor using client-go:

  • pkg/cloudprovider/vsphereparavirtual/instances_test.go
  • pkg/cloudprovider/vsphereparavirtual/instances.go
  • pkg/cloudprovider/vsphereparavirtual/loadbalancer_test.go
  • pkg/cloudprovider/vsphereparavirtual/vmoperator.go
  • pkg/cloudprovider/vsphereparavirtual/zone_test.go
  • pkg/cloudprovider/vsphereparavirtual/zone.go
  • pkg/cloudprovider/vsphereparavirtual/types.go
  • pkg/cloudprovider/vsphereparavirtual/vmservice_test.go
  • pkg/cloudprovider/vsphereparavirtual/vmservice.go
  • pkg/cloudprovider/vsphereparavirtual/fake_client_wrapper.go

Tasks

  1. XudongLiuHarold
@XudongLiuHarold XudongLiuHarold added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 24, 2024
@XudongLiuHarold
Copy link
Member Author

/assign @XudongLiuHarold @DanielXiao

@XudongLiuHarold XudongLiuHarold self-assigned this Jan 25, 2024
@XudongLiuHarold
Copy link
Member Author

I found that all the places using controller-runtime is calling each other, so it is meaningless to split it into sub-tasks, I will use one for tracking logic code and another for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant