Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide binary release of code generators #15

Closed
pwittrock opened this issue Oct 27, 2017 · 4 comments
Closed

Provide binary release of code generators #15

pwittrock opened this issue Oct 27, 2017 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@pwittrock
Copy link
Member

User story: As a user, I want a simple way to get executables for the code generators at a specific kubernetes release version.

go get gets the code generators at head, but the generators sometimes break backward compatibility. In order to get the code generators, I need to get the code at a specific release version and then manually build them. It would be simpler for some contributors if we provided them binary distributions of all of the code generators.

@munnerz
Copy link
Member

munnerz commented Oct 27, 2017

Have you seen the new generate-groups and generate-internal-groups in the root of this repo, merged in kubernetes/kubernetes#52186?

These take care of compiling the generators for you, and you are able to version against specific versions of the code-generator repository using tags.

The generated code should really be pinned and kept in sync with kubernetes/apimachinery, which consequently usually means keeping that also in sync with kubernetes/client-go and kubernetes/api.

You can see an example of this in use here: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-controller/hack/update-codegen.sh

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 24, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants