Support for different plural forms (feature request) #53
Comments
Added the beginnings of a skeleton of an integration test for PipelineRun for #61. In doing this I realized that I couldn't create PipelineParam objects with the clients b/c the plural name was wrong - it needs to be `pipelineparamses` like I'm Smeagol. I tried to work around this and stumbled on kubernetes/code-generator#53 so it doesn't seem to be possible without changing the code-generator code :( Meanwhile refactored the existing controller code to break some code out of the Reconciler, so it can be instantiated without an entire controller (instead depends only on the objects it needs). The decision about what TaskRuns to create has been separated from the logic to retrieve existing ones, and the logic to create them. (`GetTasks`, `getNextPipelineRunTaskRun`) The tests were refactored such that the success cases are in separate tests from the failure cases, so the table driven tests dont have to handle both and it's more clear what the tests are doing.
Added the beginnings of a skeleton of an integration test for PipelineRun for #61. In doing this I realized that I couldn't create PipelineParam objects with the clients b/c the plural name was wrong - it needs to be `pipelineparamses` like I'm Smeagol. I tried to work around this and stumbled on kubernetes/code-generator#53 so it doesn't seem to be possible without changing the code-generator code :( Meanwhile refactored the existing controller code to break some code out of the Reconciler, so it can be instantiated without an entire controller (instead depends only on the objects it needs). The decision about what TaskRuns to create has been separated from the logic to retrieve existing ones, and the logic to create them. (`GetTasks`, `getNextPipelineRunTaskRun`) The tests were refactored such that the success cases are in separate tests from the failure cases, so the table driven tests dont have to handle both and it's more clear what the tests are doing.
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale
…On Wed, 13 Mar 2019, 07:11 fejta-bot, ***@***.***> wrote:
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta
<https://github.com/fejta>.
/lifecycle stale
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAef3nJ_gpoZ_woQmLDBrB4PJAolt37aks5vV-3fgaJpZM4V6WD->
.
|
k8s-ci-robot
removed
the
lifecycle/stale
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@alewitt2: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We have a custom resource with a non-s plural form (Lets say a Bison CRD) - the plural of Bison is Bison.
The API server etc all seem to handle this fine, but I can't see a tag to control this in code-gen at the moment. Right now I'm handling that by post-processing the generated code (sed -e /bisons/bison/) but this is suboptimal.
The text was updated successfully, but these errors were encountered: