Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add several already-in-use kind labels to official list #2013

Closed
jberkus opened this issue Apr 6, 2018 · 7 comments
Closed

Add several already-in-use kind labels to official list #2013

jberkus opened this issue Apr 6, 2018 · 7 comments
Labels
sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@jberkus
Copy link
Contributor

jberkus commented Apr 6, 2018 •
edited

The following kind/ labels are already in wide use in the project, have meaning, and as such should be available in the official master list of labels:

  • kind/cleanup: A refactoring, API reorganization, dependency version upgrade, or other "maintenance" code change.
  • kind/design: Specifications, API designs, plans for new components and APIs.
  • kind/api-change: changes to an existing API, important to track for conformance/compatibility. Used by SIG-arch, SIG-API
  • kind/new-api: brand new APIs, should be pretty rare, but important. Used by SIG-arch

This is in addition to kind/failing-test and kind/flake, as proposed in #1579.

The following two kind labels are also in use, but should be marked as "deprecated" as they are duplicative of other labels:

  • kind/enhancement: duplicates kind/feature
  • kind/technical-debt: duplicates kind/cleanup

If this is approved, I'll open a PR against test-infra with the changes.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 6, 2018
@jberkus
Copy link
Contributor Author

jberkus commented Apr 6, 2018

/sig contributor-experience

/sig test-infra

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 6, 2018
@jberkus jberkus mentioned this issue Apr 11, 2018
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2018
@nikhita
Copy link
Member

nikhita commented Jul 6, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2018
@jberkus
Copy link
Contributor Author

jberkus commented Jul 10, 2018

I actually want to modify this issue, based on how kind/ label usage changed in 1.11

@spiffxp
Copy link
Member

spiffxp commented Jul 26, 2018

Can we close this in favor of #2032 ?

@jberkus
Copy link
Contributor Author

jberkus commented Jul 26, 2018

It's part of 2032

@jberkus
Copy link
Contributor Author

jberkus commented Jul 26, 2018

UPDATED to include kind/api-change and kind/new-api per discussion

@spiffxp spiffxp mentioned this issue Aug 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@spiffxp @jberkus @nikhita @k8s-ci-robot @fejta-bot