Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLA.md #7019

Conversation

abhilipsasahoo03
Copy link
Contributor

Signed-off-by: Abhilipsa Sahoo abhilipsasahoo03@gmail.com

Description

Enhanced readability of CLA.md file to make it more comprehensible for new contributors.

Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 1, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: abhilipsasahoo03 / name: Abhilipsa Sahoo (5bc32c8)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 1, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @abhilipsasahoo03!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @abhilipsasahoo03. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 1, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 1, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your PR
a few comments
/ok-to-test

CLA.md Outdated Show resolved Hide resolved
CLA.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2023
minor fix
CLA.md Outdated Show resolved Hide resolved
CLA.md Outdated Show resolved Hide resolved
@abhilipsasahoo03
Copy link
Contributor Author

@mrbobbytables @cpanato I have undone the changes that felt unnecessary in this case, as per your reviews. Please take a look and let me know if anything else is required.

Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
One last thing - Can you please squash/fixup the commits and remove the merge commit?

@abhilipsasahoo03
Copy link
Contributor Author

abhilipsasahoo03 commented Jan 2, 2023

Thanks!
One last thing - Can you please squash/fixup the commits and remove the merge commit?

Hi can I squash through GitHub automation or do I have to do it manually? @mrbobbytables

@mrbobbytables
Copy link
Member

Preferred is fixup manually to remove the merge commit and remove the additional commit messages. Squashing Rolls up all the messages into the top level commit message. Fixup removes the unnecessary commit messages.

@abhilipsasahoo03
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 2, 2023
@abhilipsasahoo03
Copy link
Contributor Author

abhilipsasahoo03 commented Jan 2, 2023

Preferred is fixup manually to remove the merge commit and remove the additional commit messages. Squashing Rolls up all the messages into the top level commit message. Fixup removes the unnecessary commit messages.

I would have done manually but I had to delete my local copy due to some issues. What happens if I do it via automation? @mrbobbytables

@mrbobbytables
Copy link
Member

I would have done manually but I had to delete my local copy due to some issues. What happens if I do it via automation?

The automation treats it like a full squash. All commit messages are preserved and rolled up into the final commit message. The automation makes it convenient at the cost of a quality commit message.

While it'd probably be okay here, its not something we encourage where commit history is important.

@jberkus
Copy link
Contributor

jberkus commented Jan 6, 2023

Given that the commit history isn't that important for this merge, approving.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhilipsasahoo03, jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 758bc1f into kubernetes:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants