New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CLA.md #7019
Update CLA.md #7019
Conversation
Signed-off-by: Abhilipsa Sahoo <abhilipsasahoo03@gmail.com>
|
Welcome @abhilipsasahoo03! |
Hi @abhilipsasahoo03. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your PR
a few comments
/ok-to-test
minor fix
@mrbobbytables @cpanato I have undone the changes that felt unnecessary in this case, as per your reviews. Please take a look and let me know if anything else is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One last thing - Can you please squash/fixup the commits and remove the merge commit?
Hi can I squash through GitHub automation or do I have to do it manually? @mrbobbytables |
Preferred is fixup manually to remove the merge commit and remove the additional commit messages. Squashing Rolls up all the messages into the top level commit message. Fixup removes the unnecessary commit messages. |
/label tide/merge-method-squash |
I would have done manually but I had to delete my local copy due to some issues. What happens if I do it via automation? @mrbobbytables |
The automation treats it like a full squash. All commit messages are preserved and rolled up into the final commit message. The automation makes it convenient at the cost of a quality commit message. While it'd probably be okay here, its not something we encourage where commit history is important. |
Given that the commit history isn't that important for this merge, approving. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhilipsasahoo03, jberkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Abhilipsa Sahoo abhilipsasahoo03@gmail.com
Description
Enhanced readability of CLA.md file to make it more comprehensible for new contributors.