Add Docker upstart dependency on Flannel for Ubuntu 14.04

[unicell]

Also adding respawn delay to avoid Docker respawning too fast

[1] http://upstart.ubuntu.com/cookbook/#delay-respawn-of-a-job

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: unicell

Needs approval from an approver in each of these OWNERS Files:

• ansible/OWNERS

We suggest the following people:
cc @eparis
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-reviewable]

This change is 

[ingvagabund]

What happens in you run the flannel role without docker?

[unicell]

@ingvagabund The whole roles/flannel/tasks/ubuntu.yml file is supposed to update Docker so that it can work together with Flannel, for Ubuntu distro. My change is to add service dependency to ensure Docker start after Flannel. That's in accordance to what this playbook supposed to handle.

Also, in roles/flannel/tasks/main.yml it will also try bounce docker once flanneld started. So to your question, I don't think current flannel playbook allows you to run without Docker.

[ingvagabund]

Also, in roles/flannel/tasks/main.yml it will also try bounce docker once flanneld started. So to your question, I don't think current flannel playbook allows you to run without Docker.

That's unfortunate. The docker should be de-coupled from the flannel role. Think you can do that? E.g. introduce a mechanism to detect if the docker is installed and iff notify the handler and run your new task? Introducing docker_on_system or similar variable should be sufficient for the moment (set to False be default. Then updating [1] and setting the variable to True. Unless you know a way how to detect the docker universally. I would not want to run rpm -q docker on Fedora distros and apt-get ... on other. Less if-else structures the better.

[1] https://github.com/kubernetes/contrib/blob/master/ansible/playbooks/deploy-cluster.yml#L26

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close