Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docsy] SCSS generation error #123

Closed
mrbobbytables opened this issue Apr 8, 2020 · 5 comments
Closed

[docsy] SCSS generation error #123

mrbobbytables opened this issue Apr 8, 2020 · 5 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 8, 2020

This is blocking the general development of the docsy site conversion:
There is an issue between netlify and hugo with builds throwing this error:

Error building site: TOCSS: failed to transform "scss/main.scss" (text/x-scss):
SCSS processing failed: file "stdin", line 6, col 1: File to import not found or
unreadable:  ../vendor/bootstrap/scss/bootstrap

This has temporarily been resolved by committing the generated resources directory in the WIP Preview Branch, however this should be resolved before the general docsy branch is updated for others to
work off.

@mrbobbytables mrbobbytables added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Apr 8, 2020
@mrbobbytables mrbobbytables added this to the v1.19 milestone Apr 8, 2020
@mrbobbytables mrbobbytables self-assigned this Apr 8, 2020
@miloszkowal
Copy link

What version of Hugo are you using? According to the Docsy theme, you need the extended version, downloadable here: https://github.com/gohugoio/hugo/releases

That being said, I'm also experiencing this error when trying to build a Docsy page myself, despite having this error.

@mrbobbytables
Copy link
Member Author

Tried multiple versions from v0.65.x - v0.68.3 -- by default netlify does build with the extended version as well.

The current WIP is built with v0.68.3
https://github.com/kubernetes-sigs/contributor-site/blob/d8c818706dc9adf724ec63c5044070473a52ec81/netlify.toml#L6

@mrbobbytables
Copy link
Member Author

It looks like a package.json file is required with at least these 2 dependencies:

  "dependencies": {
    "autoprefixer": "^9.7.6",
    "postcss-cli": "^7.1.0"
}

netlify will handle installing them before generating the site.

The current wip is functional but needs clean up. This issue can be closed once its cleaned up and makefile updated with correct command.

@mrbobbytables
Copy link
Member Author

This has now been resolved -- it's a combo problem:

  1. The docsy theme itself has its own submodules that must be fetched. Hugo will throw an SCSS error if they are not found. The solution is to fetch them git submodule update --init --recursive --depth 1
  2. The postcss-cli and autoprefixer JavaScript packages are required. These are installed automatically by netlify but need to be installed on a person's system for it to function.

With that, going to go ahead and close this out -- the readme on the wip branch has been updated with the notes on the above.

/close

ContribEx: contributor-site automation moved this from In Progress to Done Apr 28, 2020
@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closing this issue.

In response to this:

This has now been resolved -- it's a combo problem:

  1. The docsy theme itself has its own submodules that must be fetched. Hugo will throw an SCSS error if they are not found. The solution is to fetch them git submodule update --init --recursive --depth 1
  2. The postcss-cli and autoprefixer JavaScript packages are required. These are installed automatically by netlify but need to be installed on a person's system for it to function.

With that, going to go ahead and close this out -- the readme on the wip branch has been updated with the notes on the above.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

3 participants