Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsy conversion #122

Merged
merged 7 commits into from
May 20, 2020
Merged

Docsy conversion #122

merged 7 commits into from
May 20, 2020

Conversation

mrbobbytables
Copy link
Member

preview of docsy build

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 5, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2020
@mrbobbytables mrbobbytables force-pushed the wip-docsy branch 6 times, most recently from 52226b6 to d8c8187 Compare April 6, 2020 00:16
@mrbobbytables mrbobbytables force-pushed the wip-docsy branch 4 times, most recently from 0af94e0 to e1acc1e Compare April 14, 2020 01:19
@kushthedude
Copy link
Contributor

kushthedude commented Apr 16, 2020

@mrbobbytables I noticed some issues while setting up branch :

Building sites … ERROR 2020/04/16 19:47:40 Transformation failed: SCSS processing failed: file "stdin", line 6, col 1: File to import not found or unreadable: ../vendor/bootstrap/scss/bootstrap.

We need to use following workaround to fix this(I am not sure if this is correct way to approach it) :-

[module]

  [[module.mounts]]
    source = "static"
    target = "static"

  [[module.mounts]]
    source = "assets/scss/_variables.scss"
    target = "assets/scss/_variables"
  • Also since we are now using package.json , will it be better to use bootstrap as a node_module ?

@mrbobbytables
Copy link
Member Author

I think there is a need to commit yarn.lock too as there is only package.json.

I was avoiding yarn to mostly stay inline with docsy and the main kubernetes website that stick to npm. I should probably go ahead and commit the package-lock.json though.

We need to use following workaround to fix this(I am not sure if this is correct way to approach it)
Building sites … ERROR 2020/04/16 19:47:40 Transformation failed: SCSS processing failed: file "stdin", line 6, col 1: File to import not found or unreadable: ../vendor/bootstrap/scss/bootstrap.

🤔 Are you sure? It's being built by netlify without the module change.

@kushthedude
Copy link
Contributor

I was avoiding yarn to mostly stay inline with docsy and the main kubernetes website that stick to npm. I should probably go ahead and commit the package-lock.json though.

Yeah, any node engine would work. I installed using yarn.

We need to use following workaround to fix this(I am not sure if this is correct way to approach it)
Building sites … ERROR 2020/04/16 19:47:40 Transformation failed: SCSS processing failed: file "stdin", line 6, col 1: File to import not found or unreadable: ../vendor/bootstrap/scss/bootstrap.

🤔 Are you sure? It's being built by netlify without the module change.

Yes, The following is the error log from my machine & the issue is still open on their official repository. Maybe there could be some issue of OS. I am on macOS Catalina

@mrbobbytables
Copy link
Member Author

Yes, The following is the error log from my machine & the issue is still open on their official repository. Maybe there could be some issue of OS. I am on macOS Catalina

I'm on Mojave with Hugo v0.68.3/extended installed.
I also have the postCSS modules installed for docsy:
ref: https://www.docsy.dev/docs/getting-started/#install-postcss

@kushthedude
Copy link
Contributor

kushthedude commented Apr 16, 2020

Yes, The following is the error log from my machine & the issue is still open on their official repository. Maybe there could be some issue of OS. I am on macOS Catalina

I'm on Mojave with Hugo v0.68.3/extended installed.
I also have the postCSS modules installed for docsy:
ref: https://www.docsy.dev/docs/getting-started/#install-postcss

Same issue. BTW you have already defined both autoprefixer & postcss so npm i should have installed them already.
This is the error I am still getting #123 (comment)

@mrbobbytables
Copy link
Member Author

Do you have the extended version of hugo installed?

@kushthedude
Copy link
Contributor

Do you have the extended version of hugo installed?

Yes, Hugo Static Site Generator v0.68.3/extended darwin/amd64

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2020
@mrbobbytables mrbobbytables force-pushed the wip-docsy branch 6 times, most recently from 4c841e3 to 6aec09e Compare May 5, 2020 00:41
@mrbobbytables mrbobbytables force-pushed the wip-docsy branch 3 times, most recently from 2e284e2 to f7b6e8a Compare May 5, 2020 12:04
@mrbobbytables mrbobbytables changed the title [WIP] Docsy preview Docsy conversion May 18, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2020
@mrbobbytables
Copy link
Member Author

/hold cancel

There are still some issues, but this is in a good enough state to merge 👍

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2020
Copy link
Member

@jeefy jeefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit f5ebdc0 into kubernetes:master May 20, 2020
@mrbobbytables mrbobbytables deleted the wip-docsy branch June 14, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants