-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docsy conversion #122
Docsy conversion #122
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrbobbytables The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
52226b6
to
d8c8187
Compare
0af94e0
to
e1acc1e
Compare
@mrbobbytables I noticed some issues while setting up branch :
Building sites … ERROR 2020/04/16 19:47:40 Transformation failed: SCSS processing failed: file "stdin", line 6, col 1: File to import not found or unreadable: ../vendor/bootstrap/scss/bootstrap. We need to use following workaround to fix this(I am not sure if this is correct way to approach it) :- [module]
[[module.mounts]]
source = "static"
target = "static"
[[module.mounts]]
source = "assets/scss/_variables.scss"
target = "assets/scss/_variables"
|
I was avoiding yarn to mostly stay inline with docsy and the main kubernetes website that stick to npm. I should probably go ahead and commit the package-lock.json though.
🤔 Are you sure? It's being built by netlify without the module change. |
Yeah, any node engine would work. I installed using yarn.
Yes, The following is the error log from my machine & the issue is still open on their official repository. Maybe there could be some issue of OS. I am on macOS Catalina |
I'm on Mojave with Hugo |
Same issue. BTW you have already defined both |
Do you have the extended version of hugo installed? |
Yes, |
4c841e3
to
6aec09e
Compare
2e284e2
to
f7b6e8a
Compare
/hold cancel There are still some issues, but this is in a good enough state to merge 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
preview of docsy build
/hold