fix: enable bool-compare rule from testifylint linter (#125135)

* fix: enable bool-compare rule from testifylint linter

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* Update hack/golangci.yaml.in

Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>

* Update golangci.yaml.in

* Update golangci-strict.yaml

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml.in

* Update golangci.yaml

* Update golangci-hints.yaml

* Update golangci-strict.yaml

* Update golangci.yaml.in

* Update golangci.yaml

* Update mux_test.go

---------

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>

Kubernetes-commit: 0cde5f1e28c77496ba895ac44aff92a720c5f9c0

go.mod

@@ -13,8 +13,8 @@ require (
 	go.opentelemetry.io/otel/trace v1.20.0
 	golang.org/x/sys v0.21.0
 	google.golang.org/grpc v1.59.0
-	k8s.io/api v0.0.0-20240628062210-70c01741beda
-	k8s.io/apimachinery v0.0.0-20240628061934-adf72dd6c5c2
+	k8s.io/api v0.0.0-20240628102218-48abdb05202b
+	k8s.io/apimachinery v0.0.0-20240628175805-ef4453d2613f
 	k8s.io/client-go v0.0.0-20240628062603-ae071bc75ff9
 	k8s.io/component-base v0.0.0-20240628063534-3b0f2cefb281
 	k8s.io/cri-api v0.0.0-20240628070225-c432a0b81405

go.sum

@@ -190,10 +190,10 @@ gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
-k8s.io/api v0.0.0-20240628062210-70c01741beda h1:wQ8ASuAScWceD6yT8709GBxfyv/qevE66b3Rsi7ZJJg=
-k8s.io/api v0.0.0-20240628062210-70c01741beda/go.mod h1:Nlysps0zLruvKc0cfR9dtXQd95f5Y2XOtNtA52gutiw=
-k8s.io/apimachinery v0.0.0-20240628061934-adf72dd6c5c2 h1:Y2rD1bgpNFe3HJgKqSMzkHcOlafP3jcQLfLqADLHu3g=
-k8s.io/apimachinery v0.0.0-20240628061934-adf72dd6c5c2/go.mod h1:HaB7jl7MnnH0C8g+t13Fw226p3U88ZDog/Dt8pQRZUI=
+k8s.io/api v0.0.0-20240628102218-48abdb05202b h1:7/Ce0NylwuczxKEcN1QV3SnLX9GSZHt4Cxp1OntJ+24=
+k8s.io/api v0.0.0-20240628102218-48abdb05202b/go.mod h1:Nlysps0zLruvKc0cfR9dtXQd95f5Y2XOtNtA52gutiw=
+k8s.io/apimachinery v0.0.0-20240628175805-ef4453d2613f h1:LFzF3OPvEFldgFy9gpdsniTeVpaOCkjl38RVt9o7YkY=
+k8s.io/apimachinery v0.0.0-20240628175805-ef4453d2613f/go.mod h1:HaB7jl7MnnH0C8g+t13Fw226p3U88ZDog/Dt8pQRZUI=
 k8s.io/client-go v0.0.0-20240628062603-ae071bc75ff9 h1:O0BS42GzkKUruh8bq75c6mrkg5Ee7rsazpZdwsNToSU=
 k8s.io/client-go v0.0.0-20240628062603-ae071bc75ff9/go.mod h1:xdnfcLQaxsfDggWlUrix2Dps0Z9BFoIQyjtSLVk3n/s=
 k8s.io/component-base v0.0.0-20240628063534-3b0f2cefb281 h1:tScstMnyhlUUgsCQ6SUB7w4hKQZFmL3pYbckiOACXC4=

pkg/logs/logs_test.go

@@ -535,7 +535,7 @@ func TestReadLogsLimitsWithTimestamps(t *testing.T) {
 		//   2. The last item in the log should be 9999
 		_, err = time.Parse(time.RFC3339, string(ts))
 		assert.NoError(t, err, "timestamp not found")
-		assert.Equal(t, true, bytes.HasSuffix(logline, []byte("9999")), "is the complete log found")
+		assert.True(t, bytes.HasSuffix(logline, []byte("9999")), "is the complete log found")
 	}
 
 	assert.Equal(t, 2, lineCount, "should have two lines")