-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerequisite checks in gulp scripts #113
Comments
Unit recently, when executing gulp serve:prod another non-obvious error can occur in case environment variables are not passed to root. However, in latest version we do check GOPATH variable and the execution will exit. So, a user will most likely realize his wrong action. Anyway, in case it is simple, please add another check: cheld@estheld:~/devel/dashboard$ sudo env "GOPATH=$GOPATH" gulp serve:prod events.js:72 |
Yes, this would be extremely helpful. Most people don't realize they need godep for a frontend project. Another idea that struck me is that we could stop requiring godep and download it during a build step, e.g.,
This could actually work. |
I am on it first thing tomorrow morning :) (Moving in to my new apartment right now) |
+1 at @bryk, the download is usually quite fast |
Please consider 'go clean', because it might remove godep again. This might be non-intentional. |
Fixed. Environment variables are checked. In addition godep is downloaded by npm and does not require user setup any longer |
Fixes kubernetes#106. Added the nginx conf changes to entrypoint and api calls.…
…hanges to nginx conf
Revert changes made in kubernetes#113 to fix nginx config.
Many people fail to run Dashboard because Godep is not in path. The error message is not obvious to non-nodejs developer. Please improve the error message.
@taimir can you take over
The text was updated successfully, but these errors were encountered: