Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisite checks in gulp scripts #113

Closed
cheld opened this issue Dec 2, 2015 · 6 comments
Closed

Prerequisite checks in gulp scripts #113

cheld opened this issue Dec 2, 2015 · 6 comments

Comments

@cheld
Copy link
Contributor

cheld commented Dec 2, 2015

Many people fail to run Dashboard because Godep is not in path. The error message is not obvious to non-nodejs developer. Please improve the error message.

@taimir can you take over

@cheld
Copy link
Contributor Author

cheld commented Dec 2, 2015

Unit recently, when executing gulp serve:prod another non-obvious error can occur in case environment variables are not passed to root. However, in latest version we do check GOPATH variable and the execution will exit. So, a user will most likely realize his wrong action. Anyway, in case it is simple, please add another check:

cheld@estheld:~/devel/dashboard$ sudo env "GOPATH=$GOPATH" gulp serve:prod
[09:08:27] Requiring external module babel-core/register
[09:08:29] Using gulpfile ~/devel/dashboard/gulpfile.babel.js
[09:08:29] Starting 'assets'...
[09:08:29] Starting 'angular-templates'...
[09:08:29] Starting 'styles:prod'...
[09:08:29] Starting 'package-backend-source'...
[09:08:29] Starting 'kill-backend'...
[09:08:29] Finished 'kill-backend' after 47 μs
[09:08:29] Finished 'assets' after 103 ms
[09:08:29] Finished 'styles:prod' after 126 ms
[09:08:29] Finished 'package-backend-source' after 131 ms
[09:08:29] Starting 'backend:prod'...
execvp(): No such file or directory

events.js:72
throw er; // Unhandled 'error' event
^
Error: spawn ENOENT
at errnoException (child_process.js:988:11)
at Process.ChildProcess._handle.onexit (child_process.js:779:34)

@bryk
Copy link
Contributor

bryk commented Dec 2, 2015

Yes, this would be extremely helpful. Most people don't realize they need godep for a frontend project.

Another idea that struck me is that we could stop requiring godep and download it during a build step, e.g.,

go get godep
$GOPATH/bin/godep go <commad> 

This could actually work.

@taimir
Copy link
Contributor

taimir commented Dec 2, 2015

I am on it first thing tomorrow morning :) (Moving in to my new apartment right now)

@taimir
Copy link
Contributor

taimir commented Dec 2, 2015

+1 at @bryk, the download is usually quite fast

@cheld
Copy link
Contributor Author

cheld commented Dec 2, 2015

Please consider 'go clean', because it might remove godep again. This might be non-intentional.

@cheld
Copy link
Contributor Author

cheld commented Dec 7, 2015

Fixed. Environment variables are checked. In addition godep is downloaded by npm and does not require user setup any longer

@cheld cheld closed this as completed Dec 7, 2015
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this issue Apr 10, 2020
Fixes kubernetes#106. Added the nginx conf changes to entrypoint and api calls.…
anvithks added a commit to anvithks/k8s-dashboard that referenced this issue Apr 10, 2020
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this issue Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants