Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages consistency #1223

Closed
maciaszczykm opened this issue Sep 13, 2016 · 5 comments · Fixed by #1397
Closed

Messages consistency #1223

maciaszczykm opened this issue Sep 13, 2016 · 5 comments · Fixed by #1397
Assignees

Comments

@maciaszczykm
Copy link
Member

maciaszczykm commented Sep 13, 2016

There still is some inconsistency across Dashboard's messages. Take a look on following screenshot:

Message title shouldn't end with dot, but following message should. Like in Inbox. Now it's inconsistent.

Thing to consider is naming of Kubernetes' resources. Are we using capital letters everywhere? Do we consider resources like event, endpoint etc. as Kubernetes'? We should decide it here and then fix all messages.

@bryk
Copy link
Contributor

bryk commented Sep 13, 2016

@maciaszczykm Can you document guidelines on how we should write messages?

I can give some input, based on my experience with other UI projects. E.g., when to use sentences, when to end with dot, etc.

cc @Lukenickerson @romlein

@maciaszczykm
Copy link
Member Author

maciaszczykm commented Sep 19, 2016

I'll create short document with guidelines for the repository and after that maybe also I will be able to refactor existing messages.

If anyone has any suggestions, let me know.

@maciaszczykm
Copy link
Member Author

The next step is to review all messages across the app and fix all issues. We can also apply new localization framework everywhere.

@maciaszczykm maciaszczykm removed their assignment Oct 10, 2016
@digitalfishpond digitalfishpond self-assigned this Oct 18, 2016
@bryk
Copy link
Contributor

bryk commented Oct 20, 2016

@digitalfishpond Can you go over this? To apply i18n framework and go over messages?

@digitalfishpond
Copy link
Contributor

Yep, it's what I'm currently doing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants