Part 3 of updating strings for the new i18n framework #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase on current master? currently conflicts in PetSet and ReplicationController. Otherwise LGTM |
digitalfishpond
force-pushed
the
new-i18n-pt3
branch
from
b262654
to
ccebac3
Compare
Current coverage is 93.56% (diff: 100%)@@ master #1397 diff @@
==========================================
Files 352 352
Lines 3022 2953 -69
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2833 2763 -70
- Misses 189 190 +1
Partials 0 0
|
|
PTAL |
rf232
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 of updating strings for the new i18n framework with correct text conventions.
This concludes the update and should fix #1223