Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to client-go #1457

Closed
ianlewis opened this issue Nov 21, 2016 · 5 comments
Closed

Migrate to client-go #1457

ianlewis opened this issue Nov 21, 2016 · 5 comments
Assignees

Comments

@ianlewis
Copy link
Contributor

It may take a while but since the dashboard is essentially just a client application using the Kubernetes API, it would be good to migrate to the official Go client at some point.

Is this even feasible?

@bryk
Copy link
Contributor

bryk commented Nov 21, 2016

Yes, this should be doable. When we started the UI project there was no client-go project yet. That wa sthe reason.

@floreks
Copy link
Member

floreks commented Nov 21, 2016

We've discussed that already in #1395. Unfortunately at this point client-go can not be used by dashboard. We are using some utility functions available only in the core for now. Additionally there is a problem with object types that requires much work to resolve. I have started to work on that and even have a branch but we have to wait until these issues are resolved.

@bryk
Copy link
Contributor

bryk commented Nov 21, 2016

We are using some utility functions available only in the core for now.

Do you remember what functions are those?

@floreks
Copy link
Member

floreks commented Nov 21, 2016

k8s.io/kubernetes/pkg/controller/deployment/util, k8s.io/kubernetes/pkg/kubectl/cmd/util and probably k8s.io/kubernetes/pkg/kubectl/resource.

There might be something else though.

@ianlewis
Copy link
Contributor Author

ianlewis commented Nov 22, 2016

A cursory look also leads me to believe that it currently doesn't support exec/attach API which is required for #1345

Created an issue for it: kubernetes/client-go#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants