Client-go migration

[floreks]

This is a big change and extensive tests are needed. It will take some time to review and I can finish what's left in the meantime.

What's done

• Client-go - updated to current master, commit hash: 86a2be1b447d7abddae88de0a5f642935992b803
• 90% of the code migrated to use client-go instead of kubernetes deps
• Fixed most backend tests
• Cleaned up kubernetes dependencies. Left only the one needed for deploy from file (kubectl utils) and updated, commit hash: 871fc426b3576bfe9a92b3ca1d4bfa83ea71edd5

TODO

• Get rid of kubernetes dependencies
• Fix 10 tests that are skipped
• Fix deployment detail and not use deployment utils from kubernetes
• Fix deployment deploy not to use kubectl utils
• Enable endpoint for getting deployments old replica sets

Dashboard is running and travis should be green, however 1 endpoint is disabled and 10 tests are skipped.

In order to get rid of kubernetes as dependency and fully migrate to client-go we'd need to rewrite some code. Rewriting deployment details and getting replica sets should not be hard but getting rid of kubectl as dependency might be harder. If we want to do that then I will create issues for that.

I have not updated kubernetes dependencies because current master and 1.6.0-alpha are broken. Same dependency error as in client-go.

Closes #1457

[rf232]

Awesome, current changes look good (apart from a run of gofmt on the test code.)

In a way I'm happy that you haven't fixed the Deployment utils things yet, since I fear those are the more interesting parts to review, so being able to view them somewhat in isolation is a good thing (hint, don't squash it in the current changes :))

[codecov-io]

Codecov Report

Merging #1638 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files         372      372           
  Lines        3139     3139           
=======================================
  Hits         2926     2926           
  Misses        213      213

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0bb23...f4052c7. Read the comment docs.

[floreks]

@rf232 @ianlewis @maciaszczykm @mijajasinski

Most of the work is done. Travis is green. Only thing left is to fix some tests but I need to look a bit deeper into some of them because of the migration and this may take some time. Could you test it and maybe merge? Faster we merge, easier it will be for others to rebase their changes.

I can create issue to fix skipped tests and work on that separately.

[rf232]

Most of the work is done. Travis is green. Only thing left is to fix some tests but I need to look a bit deeper into some of them because of the migration and this may take some time. Could you test it and maybe merge? Faster we merge, easier it will be for others to rebase their changes.

Agreed, reviewing now

I can create issue to fix skipped tests and work on that separately.

SGTM

[rf232]

To get the diamond zombie slayer achievement please run:
govendor list +u | cut -c5- | xargs govendor remove

[rf232]

It is a shame we need to copy this logic from the kubernetes main repo. I think it is indeed the best option at the moment. It might be worth it to ask client-go if they can get this functionality too, so we can lift it from them and trust on them to keep the logic in sync.

[floreks]

Ye, It would be great if they could move utils also. Keeping deployment utils deps also downloads significant amount of files so I guess it's better for now to just copy these few functions and keep them in sync.

I've just checked and we do have them in our kubernetes deps. So maybe I will reuse them anyway since I have already updated kubernetes deps also and it is same version that should not conflict with client-go.

[floreks]

Just tried to reuse them and unfortunately the are using different extensions package version. We have to leave it as is for now.

[floreks]

To get the diamond zombie slayer achievement please run:
govendor list +u | cut -c5- | xargs govendor remove

Good tip. Achievement unlocked 😃