New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage class backend #1662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update comments and remember to gofmt
files.
"k8s.io/client-go/kubernetes" | ||
) | ||
|
||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've totally forgotten about comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 373 373
Lines 3149 3149
=======================================
Hits 2928 2928
Misses 221 221 Continue to review full report at Codecov.
|
Related to #1650. Backend part for StorageClass support in dashboard.
New endpoints:
/api/v1/storageclass
- returns list of storage classes in the cluster/api/v1/storageclass/{storageclassname}
- returns storage class object with given name