Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage class backend #1662

Merged
merged 3 commits into from Feb 21, 2017
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 21, 2017

Related to #1650. Backend part for StorageClass support in dashboard.

New endpoints:

  • /api/v1/storageclass - returns list of storage classes in the cluster
  • /api/v1/storageclass/{storageclassname} - returns storage class object with given name

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2017
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update comments and remember to gofmt files.

"k8s.io/client-go/kubernetes"
)

// TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've totally forgotten about comments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov-io
Copy link

codecov-io commented Feb 21, 2017

Codecov Report

Merging #1662 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1662   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         373      373           
  Lines        3149     3149           
=======================================
  Hits         2928     2928           
  Misses        221      221

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b16d05...1357c1e. Read the comment docs.

@maciaszczykm maciaszczykm merged commit fd871f3 into kubernetes:master Feb 21, 2017
@floreks floreks deleted the storage-class branch February 21, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants