Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Custom Resource Definition feature to replace Third Party Resources #2449

Closed
wants to merge 2 commits into from
Closed

[WIP] Custom Resource Definition feature to replace Third Party Resources #2449

wants to merge 2 commits into from

Conversation

kenan435
Copy link
Contributor

@kenan435 kenan435 commented Oct 9, 2017

Since Third Party Resources will be deprecated in k8s 1.8, we are introducing Custom Resource Definitions feature which is supposed to replace Third Party Resources. The two feature TPR and CRD will both be present on the dashboard during the k8s's 1.7 iteration to easy with migration from TPR's to CRD's

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 9, 2017
maciaszczykm
maciaszczykm reviewed Oct 11, 2017
View reviewed changes
src/app/backend/api/types.go
ResourceKindThirdPartyResource: {"thirdpartyresources", ClientTypeExtensionClient, true},
ResourceKindCustomResourceDefinition: {"CustomResourceDefinition", ClientTypeAPIExtensionsClient, true},
ResourceKindStorageClass: {"storageclasses", ClientTypeStorageClient, false},
ResourceKindEndpoint: {"endpoints", ClientTypeDefault, true},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful during merge if cron jobs will go to master first. It will not merge automatically due to indent change.

@maciaszczykm maciaszczykm mentioned this pull request Oct 18, 2017
Closed
@maciaszczykm maciaszczykm added this to the 1.8 milestone Oct 24, 2017
@maciaszczykm maciaszczykm removed this from the 1.8 milestone Nov 21, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2018
@kenan435
Copy link
Contributor Author

kenan435 commented Mar 4, 2018 •
edited

I'll have a look.

@maciaszczykm
Copy link
Member

Should be done after Angular migration in the new branch.

/close

@kshafiee
Copy link

Any ideas if this work is already complete? Does the dashboard support CRDs today?

@k8s-ci-robot
Copy link
Contributor

@kenan435: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2019
@shu-mutou
Copy link
Contributor

@kshafiee please refer #2493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kenan435 @fejta-bot @maciaszczykm @kshafiee @k8s-ci-robot @shu-mutou