New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to build and push multi-arch manifests #3143
Conversation
a0ca1b7
to
90029ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #3143 +/- ##
==========================================
+ Coverage 48% 48.02% +0.02%
==========================================
Files 165 165
Lines 7960 7960
Branches 24 24
==========================================
+ Hits 3821 3823 +2
+ Misses 3885 3882 -3
- Partials 254 255 +1
Continue to review full report at Codecov.
|
/assign @PeWu |
Can you pull the install docker and go into some shell script files and then run them in docker file or Travis that way? |
I have one concern regarding this change. As it requires edge docker client with manually enabled experimental flag, it might be a problem for users to use this instead of the current installation methods. At first, we should keep it only as an addition to current deployment methods and not make it the default. |
It only requires the experimental flag to push a manifest to a registry. Pulling is supported in the stable version of Docker (and has been for some time, early 2017 I believe) You could pull jeefy/kubernetes-dashboard and it will pull the correct image based on your arch. On the SIG call today, we decided to hold this back from the next release and look to merge it in after. |
Great, if this will work without additional changes to docker then I am ok with it. |
/hold Awesome! I think we're waiting till after the next release to merge this in. Once the angular migration is done we can merge this and update everything surrounding it in future PRs. |
bbca539
to
d655a9c
Compare
d655a9c
to
1ee9730
Compare
1ee9730
to
cbf9ea0
Compare
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
@jeefy Are we planning to something about it? |
I'd like to get this in the next release, yes. I want to revisit this once
metrics server support is solid.
…On Thu, Jan 3, 2019 at 10:03 AM Marcin Maciaszczyk ***@***.***> wrote:
Once the angular migration is done we can merge this and update everything
surrounding it in future PRs.
@jeefy <https://github.com/jeefy> Are we planning to something about it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3143 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVHeAWfx1AU3WBotE9aVSJEYhheuiqeks5u_hvIgaJpZM4VQbg6>
.
|
cbf9ea0
to
2b31be5
Compare
a7d64cb
to
b0c0021
Compare
@floreks @maciaszczykm PTAL, I think it's in a good place. |
/hold cancel |
@jeefy Can you solve conflicts? |
what else pending part of this pr? can we merge this? |
@mkumatag Nothing :) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeefy, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows us to publish v2.2 registry manifests allowing end-users to consume a single container image rather than specifying their architecture. This will directly address and resolve several issues (including #3137 and #2811)
Example:
docker pull kubernetes-dashboard
Instead of
docker pull kubernetes-dashbaord-amd64
Tested and verified on both Docker Hub and GCR (Only had access to a private repo sorry)
If/When this is accepted, there will be additional work updating other repos and documentation to use the Manifest image (kubernetes-dashboard) instead of individual images (kubernetes-dashboard-amd64)
Any questions or comments are appreciated!